Visitar URL original
perf: Reduce online serving hot-path overhead from metrics and audit logging by ntkathole · Pull Request #6854 · feast-dev/feast · GitHub
Skip to content

perf: Reduce online serving hot-path overhead from metrics and audit logging #6854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ntkathole merged 1 commit into from
Sep 22, 2026
Merged

perf: Reduce online serving hot-path overhead from metrics and audit logging #6854

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions sdk/python/feast/feature_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,8 @@ def _emit_online_audit(
latency_ms: float,
):
"""Best-effort audit log emission for online feature requests."""
if not feast_metrics._config.audit_logging:
return
try:
from feast.permissions.security_manager import get_security_manager

Expand Down Expand Up @@ -686,9 +688,11 @@ async def get_online_features(request: GetOnlineFeaturesRequest) -> Any:
include_feature_view_version_metadata=request.include_feature_view_version_metadata,
)

audit_start_ms = time.monotonic() * 1000
audit_start_ms = 0.0
audit_status = "success"
try:
if feast_metrics._config.audit_logging:
audit_start_ms = time.monotonic() * 1000
if store._get_provider().async_supported.online.read:
response = await store.get_online_features_async(**read_params) # type: ignore
else:
Expand All @@ -699,10 +703,11 @@ async def get_online_features(request: GetOnlineFeaturesRequest) -> Any:
audit_status = "error"
raise
finally:
audit_latency_ms = time.monotonic() * 1000 - audit_start_ms
_emit_online_audit(
request, features, entity_count, audit_status, audit_latency_ms
)
if feast_metrics._config.audit_logging:
audit_latency_ms = time.monotonic() * 1000 - audit_start_ms
_emit_online_audit(
request, features, entity_count, audit_status, audit_latency_ms
)

response_dict = await run_in_threadpool(
convert_response_to_dict, response.proto
Expand Down
7 changes: 4 additions & 3 deletions sdk/python/feast/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,6 +1829,7 @@ def _populate_response_from_feature_data(
feat_statuses = [[NOT_FOUND] * output_len for _ in range(n_features)]

feat_idx_map = {name: i for i, name in enumerate(requested_features)}
_present_count = 0
for row_idx, destinations in enumerate(indexes_tuple):
_, feature_data = read_rows[row_idx]
if feature_data is None:
Expand All @@ -1839,13 +1840,13 @@ def _populate_response_from_feature_data(
for out_idx in destinations:
feat_values[f_idx][out_idx] = feat_val
feat_statuses[f_idx][out_idx] = PRESENT
_present_count += 1

try:
from feast.metrics import track_feature_statuses

_present = sum(s == PRESENT for row in feat_statuses for s in row)
_not_found = (n_features * output_len) - _present
track_feature_statuses(table.name, _present, _not_found)
_not_found = (n_features * output_len) - _present_count
track_feature_statuses(table.name, _present_count, _not_found)
except Exception:
pass

Expand Down
25 changes: 25 additions & 0 deletions sdk/python/tests/unit/test_metrics.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1847,6 +1847,31 @@ def test_strips_version_suffix(self):
class TestEmitOnlineAudit:
"""Tests for the _emit_online_audit helper in feature_server."""

def test_skips_when_audit_logging_disabled(self):
from feast.feature_server import GetOnlineFeaturesRequest, _emit_online_audit

request = GetOnlineFeaturesRequest(
entities={"driver_id": [1]},
features=["driver_fv:conv_rate"],
)

with (
patch("feast.feature_server.feast_metrics") as mock_metrics,
patch(
"feast.permissions.security_manager.get_security_manager",
) as mock_sm,
):
mock_metrics._config.audit_logging = False
_emit_online_audit(
request=request,
features=request.features,
entity_count=1,
status="success",
latency_ms=10.0,
)
mock_metrics.emit_online_audit_log.assert_not_called()
mock_sm.assert_not_called()

def test_emits_audit_log_with_anonymous_user(self):
from feast.feature_server import GetOnlineFeaturesRequest, _emit_online_audit

Expand Down
Loading