Visitar URL original
feat: Add dualStack server option to the Feast operator by dbbvitor · Pull Request #6887 · feast-dev/feast · GitHub
Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: Cover -h boundary positions in withBindHost
Mutation testing found survivors in withBindHost's loop bounds: an -h
flag as the very last argument (no value to replace) and one as the
first argument were both untested edge cases.

Signed-off-by: dbbvitor <vitor.diniz@gympass.com>
  • Loading branch information
dbbvitor committed Sep 28, 2026
commit 5e787656051ded480a766a79d2f41002dcb2cf38
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,8 @@ func TestWithBindHost(t *testing.T) {
{"online bracketed", OnlineFeastType, []string{"serve", "--metrics", "-h", hostAllIPv4}, dual, []string{"serve", "--metrics", "-h", "[::]"}},
{"offline bracketed", OfflineFeastType, []string{"serve_offline", "-h", hostAllIPv4}, dual, []string{"serve_offline", "-h", "[::]"}},
{"ui bare", UIFeastType, []string{"ui", "-h", hostAllIPv4}, dual, []string{"ui", "-h", "::"}},
{"-h as first arg is still replaced", LineageFeastType, []string{"-h", hostAllIPv4}, dual, []string{"-h", "::"}},
{"-h with no following value does not panic or get touched", OnlineFeastType, []string{"serve", "-h"}, dual, []string{"serve", "-h"}},
{"lineage bare", LineageFeastType, []string{"serve_lineage", "-h", hostAllIPv4}, dual, []string{"serve_lineage", "-h", "::"}},
{"registry has no host flag", RegistryFeastType, []string{"serve_registry"}, dual, []string{"serve_registry"}},
}
Expand Down
Loading