Repository navigation
fix: Use UTC end bound and correct docs for disable_event_timestamp - #6956
Open
patelchaitany wants to merge 2 commits into
Open
patelchaitany wants to merge 2 commits into
patelchaitany wants to merge 2 commits into
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6956 +/- ##
=======================================
Coverage 49.49% 49.49%
=======================================
Files 443 443
Lines 55450 55448 -2
Branches 8085 8085
=======================================
+ Hits 27443 27445 +2
+ Misses 26109 26106 -3
+ Partials 1898 1897 -1
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
Collaborator
|
can we explicitly say it is utc now? |
patelchaitany
force-pushed
the
fix/disable-event-timestamp-docs-and-utc
branch
from
October 7, 2026 05:30
39a5451 to
cbae98f
Compare
Contributor
Author
Done, the docstrings and CLI help now say "from 1970-01-01 up to the current UTC time" |
patelchaitany
force-pushed
the
fix/disable-event-timestamp-docs-and-utc
branch
from
October 7, 2026 06:50
cbae98f to
60a9ab4
Compare
ntkathole
force-pushed
the
fix/disable-event-timestamp-docs-and-utc
branch
from
October 7, 2026 11:20
60a9ab4 to
dcff28c
Compare
patelchaitany
force-pushed
the
fix/disable-event-timestamp-docs-and-utc
branch
from
October 7, 2026 12:34
dcff28c to
d1a4c2f
Compare
disable_event_timestamp was documented as stamping rows with the current datetime, but no materialization engine reads the flag; rows keep their source event timestamps. Update docstrings, CLI help and docs so the flag only promises full-window materialization. Also compute the full-window bounds in UTC. The CLI and feature server used naive datetime.now(), which make_tzaware() treats as UTC, so hosts west of UTC skipped the newest rows. Fixes feast-dev#6936 Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
Signed-off-by: Chaitany Patel <patelchaitany93@gmail.com>
patelchaitany
force-pushed
the
fix/disable-event-timestamp-docs-and-utc
branch
from
October 8, 2026 07:23
d1a4c2f to
df9c47d
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
disable_event_timestamp(CLI--disable-event-timestamp,FeatureStore.materialize, feature server/materialize) was documented as materializing all data "using current datetime as event timestamp". No materialization engine reads the flag, so rows always keep their source event timestamps (see #6936).This PR:
feature_store.py,infra/provider.py), the CLI help,README.md, the README template, and the pages underdocs/. The flag now only promises full-window materialization (1970-01-01 → now), and the docs say rows keep their source event timestamps. It also drops the "useful when source data lacks event timestamps" wording, because the offline pull still requirestimestamp_field.datetime.now().make_tzaware()then treats that value as UTC, so on hosts west of UTC the window ended hours early and the newest rows were silently skipped. Both now usedatetime(1970, 1, 1, tzinfo=timezone.utc)→_utc_now().Implementing "overwrite with current time" is intentionally out of scope. It would need changes in every engine, it could hide stale data behind a fresh timestamp, and it still would not help sources that have no timestamp column.
Which issue(s) this PR fixes:
Fixes #6936
Checks
git commit -s)Testing Strategy
Added
test_parse_materialize_timestamps_disable_event_timestamp_uses_utc, which checks that both bounds are tz-aware UTC and that the end bound matches the real UTC now. I ran it together with the existing materialize CLI/server tests underTZ=America/Los_Angeles: 4 passed.🤖 Generated with Claude Code