Visitar URL original
docs: Fix remote HTTP session cleanup examples by Hanabi9249 · Pull Request #6967 · feast-dev/feast · GitHub
Skip to content

docs: Fix remote HTTP session cleanup examples - #6967

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
Hanabi9249:codex/docs-example-contract
Oct 9, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
Hanabi9249:codex/docs-example-contract

Conversation

@Hanabi9249

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The remote online store guide recommends using FeatureStore as a synchronous context manager and calling store.close() without awaiting it. FeatureStore does not implement that context manager protocol, and its close() method is asynchronous, so these examples either fail before retrieval or leave HTTP session cleanup unexecuted.

Replace the synchronous examples with HttpSessionManager.close_session() in a finally block, document await store.close() for asynchronous applications, and explain that the cached HTTP session is shared within the process.

Which issue(s) this PR fixes:

No linked issue.

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format.

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Validated the example's Python syntax, checked the cleanup calls against the current source contract and async provider chain, and ran git diff --cached --check. These are static documentation checks; the example was not executed against Feast. Feast CLI, unit tests, remote-server integration, and Sphinx build were not run.

Release notes

NONE

@Hanabi9249
Hanabi9249 requested a review from a team as a code owner October 7, 2026 22:48

Copy link
Copy Markdown
Contributor Author

Could a maintainer familiar with the remote online store review the synchronous finally cleanup using HttpSessionManager.close_session() and the separate await store.close() example for async applications? These match the current asynchronous close signature and the process-wide cached session. The snippets passed syntax and source-contract checks; Feast runtime and remote-server integration have not been run. DCO is green, and the integration checks are skipped.

Signed-off-by: Hanabi <3666353208@qq.com>
@ntkathole
ntkathole force-pushed the codex/docs-example-contract branch from cef2a22 to 793b443 Compare October 9, 2026 09:12
@ntkathole
ntkathole merged commit fee8f6c into feast-dev:master Oct 9, 2026
10 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants