Visitar URL original
fix: Convert PdfBytes values to protos like ImageBytes by raashish1601 · Pull Request #6968 · feast-dev/feast · GitHub
Skip to content

fix: Convert PdfBytes values to protos like ImageBytes #6968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
haoxu0 merged 3 commits into from
Oct 9, 2026
+10 −0
Merged

fix: Convert PdfBytes values to protos like ImageBytes #6968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c469145
fix: Convert PdfBytes values to protos like ImageBytes
raashish1601 Oct 7, 2026
120157d
Merge branch 'master' into fix/pdf-bytes-proto-conversion
haoxu0 Oct 8, 2026
fb0d3c3
Merge branch 'master' into fix/pdf-bytes-proto-conversion
haoxu0 Oct 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sdk/python/feast/type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,7 @@ def _type_err(item, dtype):
),
ValueType.STRING: ("string_val", lambda x: str(x), None),
ValueType.BYTES: ("bytes_val", lambda x: x, {bytes}),
ValueType.PDF_BYTES: ("bytes_val", lambda x: x, {bytes}),
ValueType.IMAGE_BYTES: ("bytes_val", lambda x: x, {bytes}),
ValueType.BOOL: ("bool_val", lambda x: x, {bool, np.bool_, int, np.int_}),
ValueType.UUID: ("uuid_val", lambda x: str(x), {str, uuid_module.UUID}),
Expand Down
9 changes: 9 additions & 0 deletions sdk/python/tests/unit/test_type_map.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,15 @@ def test_python_values_to_proto_values_bytes_to_list(values, value_type, expecte
assert converted == expected


@pytest.mark.parametrize(
"value_type", [ValueType.BYTES, ValueType.PDF_BYTES, ValueType.IMAGE_BYTES]
)
def test_python_values_to_proto_values_binary(value_type):
protos = python_values_to_proto_values([b"%PDF-1.3", None], value_type)
assert feast_value_type_to_python_type(protos[0]) == b"%PDF-1.3"
assert feast_value_type_to_python_type(protos[1]) is None


def test_python_values_to_proto_values_bytes_to_list_not_supported():
with pytest.raises(TypeError):
_ = python_values_to_proto_values([b"[]"], ValueType.BYTES_LIST)
Expand Down
Loading