Visitar URL original
docs: Fix ClickHouse offline store type in configuration example by Hanabi9249 · Pull Request #6971 · feast-dev/feast · GitHub
Skip to content

docs: Fix ClickHouse offline store type in configuration example - #6971

Merged
ntkathole merged 1 commit into
feast-dev:masterfrom
Hanabi9249:codex/docs-store-type-example
Oct 9, 2026
Merged

ntkathole merged 1 commit into
feast-dev:masterfrom
Hanabi9249:codex/docs-store-type-example

Conversation

@Hanabi9249

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

The ClickHouse offline store example uses a fully qualified store class as type, but ClickhouseOfflineStoreConfig accepts only clickhouse. After replacing the connection placeholders, copying the example still produces a configuration validation error.

Use the existing clickhouse alias. It resolves to the same store class and satisfies its configuration model.

Which issue(s) this PR fixes:

No linked issue. This does not change ClickHouse query generation covered by #6775 / #6141.

Checks

  • I've made sure the tests are passing.
  • My commits are signed off (git commit -s)
  • My PR title follows conventional commits format.

Testing Strategy

  • Unit tests
  • Integration tests
  • Manual tests
  • Testing is not required for this change

Parsed both YAML examples with existing PyYAML 6.0.3. With DB_PORT replaced by integer 8123 in both inputs, the unchanged source definitions of FeastConfigBaseModel, ClickhouseConfig, and ClickhouseOfflineStoreConfig were executed using existing Pydantic 2.12.5: the original reports only a type literal error; the updated example passes. The unchanged source store-type selector resolves both values to the same class. git diff --cached --check passes.

This is isolated source-model validation. Full Feast/RepoConfig integration, CLI, unit suite, ClickHouse connections, and Sphinx were not run.

Release notes

NONE

@Hanabi9249
Hanabi9249 requested a review from a team as a code owner October 8, 2026 00:52

@haoxu0 haoxu0 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ntkathole
ntkathole force-pushed the codex/docs-store-type-example branch from f1c4125 to cd8d0b2 Compare October 9, 2026 07:40
@ntkathole
ntkathole merged commit ac47f30 into feast-dev:master Oct 9, 2026
10 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants