Repository navigation
fix: Accept the store selector in Faiss configuration - #6972
Open
Hanabi9249 wants to merge 2 commits into
Open
Hanabi9249 wants to merge 2 commits into
Hanabi9249 wants to merge 2 commits into
Conversation
Signed-off-by: Hanabi <3666353208@qq.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6972 +/- ##
=======================================
Coverage 49.92% 49.92%
=======================================
Files 443 443
Lines 55511 55512 +1
Branches 8096 8096
=======================================
+ Hits 27714 27715 +1
Misses 25874 25874
Partials 1923 1923
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Loading the documented Faiss YAML fails because
FaissOnlineStoreConfighas notypefield and its base model forbids extra fields.RepoConfigforwards the selector in the original dictionary to the configuration model.Declare the fully qualified store selector with a default. This lets the documented configuration validate and retains the selector when the model is serialized and reconstructed by the online store. Add regression cases for the documented configuration and model round-trip using the existing Faiss test fixture.
Which issue(s) this PR fixes:
No linked issue.
Checks
git commit -s)Testing Strategy
With existing Pydantic 2.12.5 and PyYAML 6.0.3, executed the exact original/fixed configuration class definitions and unchanged
FeastConfigBaseModel. The same YAML from the current Faiss documentation reports onlytype / extra_forbiddenbefore the change and validates afterward. Default selector and model round-trip pass; required-field and unknown-field controls retain their expected rejections. The added regression module compiles, andgit diff --cached --checkpasses.Validation loaded only source class segments. Full Feast/RepoConfig construction, the repository pytest module (including the added regression methods), CLI, FAISS native import/training/search, full suites and Sphinx were not run. No dependencies were installed.
Release notes
NONE