Repository navigation
fix: Remove unsupported vector_len from PostgreSQL tutorial config - #6973
Open
Hanabi9249 wants to merge 1 commit into
Open
Hanabi9249 wants to merge 1 commit into
Hanabi9249 wants to merge 1 commit into
Conversation
Signed-off-by: Hanabi <3666353208@qq.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PGVector tutorial's complete feature_store.yaml includes online_store.vector_len: 384. The current PostgreSQLOnlineStoreConfig inherits a Pydantic model with extra="forbid" and does not declare this field, so this public configuration fails validation with extra_forbidden.
Remove the unsupported field while retaining vector_enabled: true. The current PostgreSQL backend uses that flag to select its vector column type and does not read a vector_len configuration option.
Validation used the exact unchanged configuration class bodies with real installed Pydantic 2.12.5 and PyYAML 6.0.3. The original tree produced 28 passing cases and one failure on this YAML; the patched tree passed the same 29 cases (18 public configuration schema inputs and 11 controls). git diff --cached --check also passed. Full Feast/RepoConfig integration, CLI execution, database services, and the end-to-end tutorial were not run.