@colebemis Since you included this google icon you can close mine in #93 or use it with a '+' for google plus

hi, what is the hold up here?

No way to merge this?

@colebemis Since you included this google icon you can close mine in #93 or use it with a '+' for google plus

Google plus is closing

No way to merge this?

@colebemis have to review first

I'll take a look at this today 👍 Sorry for the delay 😅

@fauxparse It looks like this icon is located in a icons/logos directory. Could you move into the icons directory?

@fauxparse It looks like this icon is located in a icons/logos directory. Could you move into the icons directory?

Done. I guess the logos directory existed when I made the pull request back in August... ;)

@colebemis Should be good to go now.

Codecov Report

Merging #114 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##           master   #114   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines          34     34           
  Branches        3      3           
=====================================
  Hits           34     34

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d42ac8...1ccdf79. Read the comment docs.

What's the hold up on this?

Would love to have this!

Hey there, any reason this hasn't be merged yet? I too would love to have the Google logo for my Google AOuth button rather than relying on some PNG icon.

Hey there, any reason this hasn't be merged yet?

Waiting for @colebemis ...

There should be a minimum of 2px of spacing

If I adjust the font awesome google icon (https://fontawesome.com/icons/google?style=brands) to have just the line, then it looks like this:

@fauxparse Could you adjust it to look similar like that?

@fauxparse Could you adjust it to look similar like that?

This PR is over two years old, I'm really not sure I need to.

@colebemis Could you take a look at this? This PR is quite old...

@colebemis please? Looks like all it needs at this point is one last approval. I think a lot of people are waiting for this

Sadly it looks like @colebemis doesn't want to merge new icons...

@colebemis I'll send you $5 in bitcoins if you just click that merge button. Please, oh please mighty maintainer, let us have this. We do not ask for much. We are but some humble developers, trying to make a living, barely getting by, craving that beautiful G. We never questioned your authority, never even as much as glanced at the new font-awesome icons. Have mercy with us, o mighty maintainer.

@omnibrain not sure that's how things work. And what prevents you from downloading the svg from @fauxparse's fork or using his whole repo?

@locness3 using the official package is obviously nicer than using some fork but I guess that‘s what I‘ll do. I think what bothers me is that I don‘t see any reason for this not to be merged? Has feather icons reached the end of development? I‘m OK with any explanation, but no explanation at all is hard to accept.

@omnibrain Brand icons are deprecated in feather, read #763, tho it would be cool to merge the current brand icons requests and only reject further ones.
But more generally @colebemis doesn't give any sign of life concerning this project.

@omnibrain Brand icons are deprecated in feather

That's a harsh decision. Deprecating all brand icons instead of accepting the ones that are simple enough?
That's like deprecating all icons because most are too complex and complicated to be drawn in a 24x24px grid.

The problem, i guess, is brand icons are unique, and not adaptable to any icon set.

And if all you need are brand icons SVGs, simpleicons.com dors the job.

Everyone who wants to manually add the icon, here is the path from simpleicons a little bit adjusted:

<symbol id="google" viewBox="0 0 24 24">
    <path d="M12.219 10.43 12.219 14.199 18.457 14.199C18.207 15.816 16.574 18.941 12.219 18.941 8.465 18.941 5.402 15.836 5.402 12 5.402 8.164 8.469 5.059 12.219 5.059 14.355 5.059 15.785 5.965 16.605 6.754L19.59 3.875C17.672 2.086 15.188 1 12.219 1 6.137 1 1.219 5.918 1.219 12 1.219 18.082 6.137 23 12.219 23 18.57 23 22.781 18.535 22.781 12.25 22.781 11.527 22.703 10.977 22.605 10.43ZM12.219 10.43"/>
</symbol>

I'll echo @fauxparse @omnibrain and say that this would be soooo helpful!

@colebemis Please? 🙏🏼

As per #763, brand icons have been deprecated here in favour of Simple Icons, where this is already available: https://simpleicons.org/?q=Google

Ah yes, I saw that. I wasn't sure if that was the final decision yet or not. I found this substitution too, which sort of looks in the style of feather.

when will this get merged ?

Never #763