Visitar URL original
Added script for creating a file with all of the icons. by ExPixel · Pull Request #118 · feathericons/feather · GitHub
Skip to content

Added script for creating a file with all of the icons. - #118

Closed
ExPixel wants to merge 2 commits into
feathericons:masterfrom
ExPixel:master
Closed

Added script for creating a file with all of the icons.#118
ExPixel wants to merge 2 commits into
feathericons:masterfrom
ExPixel:master

Conversation

@ExPixel

@ExPixel ExPixel commented Jun 18, 2017

Copy link
Copy Markdown

Usually it would be better to use a build tool to import only the icons you use and build a file like this specific to your project, but having a single file with all of the icons can be convenient for some scenarios (mine).

Lets you use the icons like this:

<svg class="icon">
    <use xlink:href="/path/to/feather.svg#calendar" />
</svg>

@Swizz

Swizz commented Jun 18, 2017

Copy link
Copy Markdown

Take a look at #101, here we reach a consensus on how Feather will be used.

@ExPixel

ExPixel commented Jun 18, 2017

Copy link
Copy Markdown
Author

This is #2 on the list of the stuff that consensus has been reached on:

An SVG sprite sheet should be generated from the icons directory.

I just didn't see a spritesheet in the repo yet.

@colebemis

colebemis commented Jun 30, 2017

Copy link
Copy Markdown
Member

@ExPixel Thanks so much for your contribution! Just wanted to let you know that I'm not ignoring this pull. I just want to hold off merging anything right now because I'm about to make some significant organizational changes to the repo.

@ExPixel ExPixel closed this Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ExPixel @Swizz @colebemis