Visitar URL original
Updated replace() to pass id from placeholder element by bbohen · Pull Request #193 · feathericons/feather · GitHub
Skip to content

Updated replace() to pass id from placeholder element #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colebemis merged 3 commits into from
Oct 11, 2017
Merged

Updated replace() to pass id from placeholder element #193

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
535af99
feat: Updated replace() to pass id from placeholder element
bbohen Oct 5, 2017
5b81d08
refactor: Fixes minor typo
bbohen Oct 5, 2017
e6996bf
refactor: Updated name of constant for consistency
bbohen Oct 5, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
refactor: Updated name of constant for consistency
  • Loading branch information
@bbohen
bbohen committed Oct 5, 2017
commit e6996bfe15e5b7d610c0e76ee83892fbcc084bff
5 changes: 3 additions & 2 deletions src/replace.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,12 +42,13 @@ function replaceElement(element, options) {
}

const elementClassAttr = element.getAttribute('class') || '';
const elementId = element.getAttribute('id');
const elementIdAttr = element.getAttribute('id');
const classNames = (
options.class ? `${options.class} ${elementClassAttr}` : elementClassAttr
);

const svgString = toSvg(key, Object.assign({}, options, { class: classNames, id: elementId }));
const svgOptions = Object.assign({}, options, { class: classNames, id: elementIdAttr });
const svgString = toSvg(key, svgOptions);
const svgDocument = new DOMParser().parseFromString(svgString, 'image/svg+xml');
const svgElement = svgDocument.querySelector('svg');

Expand Down