Visitar URL original
feat(svg-sprite): Adds build sprite script with tests and docs by ivanquirino · Pull Request #319 · feathericons/feather · GitHub
Skip to content

feat(svg-sprite): Adds build sprite script with tests and docs #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colebemis merged 8 commits into from
Feb 21, 2018
Merged

feat(svg-sprite): Adds build sprite script with tests and docs #319

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
5996edc
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 19, 2018
c28aeea
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 20, 2018
7b5bdfa
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 20, 2018
32ca4bb
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 20, 2018
e97a39e
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 20, 2018
ba70b75
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 20, 2018
abf4b1e
feat(svg-sprite): Adds build sprite script with tests and docs
Feb 20, 2018
1935455
feat(svg-sprite): fixes and recommendations
Feb 20, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
feat(svg-sprite): fixes and recommendations
  • Loading branch information
Ivan Quirino
Ivan Quirino committed Feb 20, 2018
commit 19354553b36a3ed85047a5d4a06231ed718f2b6c
16 changes: 8 additions & 8 deletions bin/__tests__/__snapshots__/build-sprite-string.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

exports[`builds sprite correctly 1`] = `
"<svg xmlns=\\"http://www.w3.org/2000/svg\\">
<defs>
<symbol id=\\"icon1\\" viewBox=\\"0 0 24 24\\">
<line x1=\\"23\\" y1=\\"1\\" x2=\\"1\\" y2=\\"23\\"></line><line x1=\\"1\\" y1=\\"1\\" x2=\\"23\\" y2=\\"23\\"></line>
</symbol>
<symbol id=\\"icon2\\" viewBox=\\"0 0 24 24\\">
<circle cx=\\"12\\" cy=\\"12\\" r=\\"11\\"></circle>
</symbol>
</defs>
<defs>
<symbol id=\\"icon1\\" viewBox=\\"0 0 24 24\\">
<line x1=\\"23\\" y1=\\"1\\" x2=\\"1\\" y2=\\"23\\"></line><line x1=\\"1\\" y1=\\"1\\" x2=\\"23\\" y2=\\"23\\"></line>
</symbol>
<symbol id=\\"icon2\\" viewBox=\\"0 0 24 24\\">
<circle cx=\\"12\\" cy=\\"12\\" r=\\"11\\"></circle>
</symbol>
</defs>
</svg>"
`;
12 changes: 5 additions & 7 deletions bin/build-sprite-string.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
import defaultAttrs from '../src/default-attrs.json';

const svgStartTag = `<svg xmlns="${defaultAttrs.xmlns}">
<defs>\n`;
const svgEndTag = ' </defs>\n</svg>';
const svgStartTag = `<svg xmlns="${defaultAttrs.xmlns}">\n<defs>\n`;
const svgEndTag = '</defs>\n</svg>';

/**
* Renders the inner sprites as SVG Symbols
Expand All @@ -12,7 +11,7 @@ const svgEndTag = ' </defs>\n</svg>';
function buildSpriteString(icons) {
const symbols = Object.keys(icons)
.map(icon => toSvgSymbol(icon, icons[icon]))
.reduce((spriteString, symbolString) => spriteString + symbolString, '');
.join('');

return svgStartTag + symbols + svgEndTag;
}
Expand All @@ -24,9 +23,8 @@ function buildSpriteString(icons) {
* @returns {string} the rendered SVG symbol
*/
function toSvgSymbol(name, contents) {
return ` <symbol id="${name}" viewBox="${defaultAttrs.viewBox}">
${contents}
</symbol>\n`;
return `<symbol id="${name}" viewBox="${defaultAttrs.viewBox}">
${contents}\n</symbol>\n`;
}

export default buildSpriteString;