Visitar URL original
fix: default custom-env-config settings caused name conflicts by FossPrime · Pull Request #3193 · feathersjs/feathers · GitHub
Skip to content

fix: default custom-env-config settings caused name conflicts #3193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FossPrime wants to merge 6 commits into
base: dove
Choose a base branch
from
Open

fix: default custom-env-config settings caused name conflicts #3193

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e5e254b
fix: default custom-env-config settings caused name conflicts
FossPrime May 19, 2023
31fe6cc
Add origins configuration
FossPrime Jun 5, 2023
4ab6a6a
Update client.test.tpl.ts
FossPrime Jun 6, 2023
08c5526
Update app.test.tpl.ts
FossPrime Jun 6, 2023
165d0ad
Update configuration.tpl.tsS
FossPrime Jun 6, 2023
c41013a
Update configuration.tpl.tsS
FossPrime Jun 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update configuration.tpl.tsS
  • Loading branch information
@FossPrime
FossPrime authored Jun 6, 2023
commit c41013af3585eec6dc27da771a49b50b54e8426a
6 changes: 3 additions & 3 deletions packages/generators/src/app/templates/configuration.tpl.tsS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ export const configurationSchema = {
...defaultAppSettings,
port: { type: 'number' },
public: { type: 'string' },
origins: Type.Array(Type.String())
origins: { type: 'array', items: { type: 'string' } }
}
} as const

Expand All @@ -65,9 +65,9 @@ import { dataValidator } from './validators'
export const configurationSchema = Type.Intersect([
defaultAppConfiguration,
Type.Object({
host: Type.String(),
port: Type.Number(),
public: Type.String()
public: Type.String(),
origins: Type.Array(Type.String())
})
])

Expand Down