Visitar URL original
feat(firestore): Expose Async Firestore Client. by jkyle109 · Pull Request #621 · firebase/firebase-admin-python · GitHub
Skip to content

feat(firestore): Expose Async Firestore Client. - #621

Merged
jkyle109 merged 5 commits into
async-firestorefrom
je-async-firestore
Jul 13, 2022
Merged

feat(firestore): Expose Async Firestore Client.#621
jkyle109 merged 5 commits into
async-firestorefrom
je-async-firestore

Conversation

@jkyle109

@jkyle109 jkyle109 commented Jul 5, 2022 •
edited by lahirumaramba
Loading

Copy link
Copy Markdown
Contributor

Adds the feature of using an Async Firestore connection by exposing the Async Firestore Client.

Related to #104

lahirumaramba
lahirumaramba requested changes Jul 7, 2022
View reviewed changes

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Thanks @jkyle109
Added a few comments mostly just nits and some feedback on type hints.

Comment thread firebase_admin/firestore_async.py Outdated
Comment thread firebase_admin/firestore_async.py Outdated
Comment thread firebase_admin/firestore_async.py Outdated
Comment thread firebase_admin/firestore_async.py
Comment thread firebase_admin/firestore_async.py Outdated
Comment thread tests/test_firestore_async.py Outdated
@lahirumaramba lahirumaramba removed their assignment Jul 7, 2022
@jkyle109
jkyle109 requested a review from lahirumaramba July 12, 2022 15:54
@jkyle109
jkyle109 requested a review from markarndt July 12, 2022 20:12
@markarndt
markarndt self-requested a review July 12, 2022 20:34
lahirumaramba
lahirumaramba approved these changes Jul 13, 2022
View reviewed changes

@lahirumaramba lahirumaramba left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkyle109
jkyle109 merged commit 1536e33 into async-firestore Jul 13, 2022
@lahirumaramba lahirumaramba mentioned this pull request Jul 15, 2022
Open
jkyle109 added a commit that referenced this pull request Aug 24, 2022
@jkyle109 @lahirumaramba
feat(firestore): Async Firestore (#635)
e1c6c6f 
* feat(firestore): Expose Async Firestore Client. (#621)

* feat(firestore): Expose Async Firestore Client.

* fix: Added type hints and defintion wording changes

* fix: removed future annotations until Python 3.6 is depreciated.

* fix: added missed type and clarifying comment for Python 3.6 type hinting.

* fix: lint

* Adds integration tests for the Async Firstore module (#623)

* Add integration tests for async firstore module

* fix: made pytest Python 3.6 compatible

* Trigger Integration Tests

* fix: correct copyright year

* Add code snippets for firestore modules. (#628)

* Add code snippets for firestore modules.

* fix: clarified snippet names and fixed newline.

* fix: Removed var tags. These won't work as I intended it to since html is escaped when using includecode.

Co-authored-by: Lahiru Maramba <llahiru@gmail.com>
@coderabbitai coderabbitai Bot mentioned this pull request Apr 14, 2026
Merged
2 of 7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lahirumaramba lahirumaramba lahirumaramba approved these changes
@vkryachko vkryachko Awaiting requested review from vkryachko
+1 more reviewer
@markarndt markarndt markarndt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@jkyle109 jkyle109

Labels

api: firestore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jkyle109 @lahirumaramba @markarndt