Visitar URL original
Auto-update dependencies. by dpebot · Pull Request #1361 · firebase/functions-samples · GitHub
Skip to content

Auto-update dependencies. - #1361

Merged
jhuleatt merged 1 commit into
mainfrom
dpebot-repositorygardener
Oct 8, 2026
Merged

jhuleatt merged 1 commit into
mainfrom
dpebot-repositorygardener

Conversation

@dpebot

@dpebot dpebot commented Oct 8, 2026

Copy link
Copy Markdown
Collaborator

Brought to you by your friendly Repository Gardener.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates dependency versions in multiple package.json files, including upgrading firebase, @firebase/functions, and firebase-functions. Feedback points out that @firebase/functions is redundant and should be removed from the client dependencies to avoid potential duplicate installations and version mismatches, as the main firebase package is already used.

},
"dependencies": {
"@firebase/functions": "^0.13.6",
"@firebase/functions": "^0.14.0",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The @firebase/functions package is redundant because the project already depends on the main firebase package and imports functions directly from 'firebase/functions' in main.ts. Keeping both can lead to duplicate installations and potential runtime issues due to version mismatches. It is recommended to remove @firebase/functions from the dependencies.

@jhuleatt
jhuleatt force-pushed the dpebot-repositorygardener branch from 1895174 to 60da346 Compare October 8, 2026 14:38
@jhuleatt
jhuleatt merged commit c698fa6 into main Oct 8, 2026
16 checks passed
@jhuleatt
jhuleatt deleted the dpebot-repositorygardener branch October 8, 2026 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants