set_color: list valid color aliases - #13062

Is brown equal to yellow or is that only in my settings?

FYI this is my first time in Rust so please double check I didn't do anything stupid. Let's see if the tests pass, not sure if these attributes are used anywhere else in the code...

You should squash some of those commits. The history doesn't need to keep track of every silly mistakes, missed formatting, and whatnot. It makes the git history harder to read, git blame less informative, and reverting changes more painful.
There should be only 2, maybe 3, commits here:

• the doc update
• the removal of _rgb and hidden
• maybe the +1 for the capacity, but since it's such a minor change, it could be squashed with the field removal.

As for the change itself, I think it would be better if set_color --print-colors put the identical colors on the same line. As-is, if one doesn't read the documentation, one might wonder what the difference is between, say yellow and brown, especially since the way the brain interprets color is very context sensitive (i.e. the yellow and brown might appear slightly different) ¹

You should squash some of those commits.

Could also do this automatically when merging the PR, less work for everyone.

I think it would be better if set_color --print-colors put the identical colors on the same line.

That might be beyond my current level of Rust abilities...

You should squash some of those commits.

Could also do this automatically when merging the PR, less work for everyone.

How would an automated system know which commits to squash together? That only works if the goal is to squash everything into a single commit, not in 2 or 3.

And, put bluntly, you created that mess of commits in the first place, some of which don't even compile! And now you're asking someone else to fix some basic commit hygiene issues that shouldn't have existed in the first place?

I'm fine with 1 commit or 3 separate PRs if that makes more sense. Most repos I contribute to only do squash merges. This is also my first time writing Rust, so apologies for the messy history.