Visitar URL original
Add StringAssertions::NotBeEquivalentTo by danielmpetrov · Pull Request #1134 · fluentassertions/fluentassertions · GitHub
Skip to content

Add StringAssertions::NotBeEquivalentTo - #1134

Merged
jnyrup merged 5 commits into
fluentassertions:masterfrom
danielmpetrov:gh_997
Sep 10, 2019
Merged

Add StringAssertions::NotBeEquivalentTo#1134
jnyrup merged 5 commits into
fluentassertions:masterfrom
danielmpetrov:gh_997

Conversation

@danielmpetrov

@danielmpetrov danielmpetrov commented Sep 9, 2019

Copy link
Copy Markdown
Contributor

Closes #997

jnyrup
jnyrup requested changes Sep 9, 2019
View reviewed changes

@jnyrup jnyrup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.

Comment thread Src/FluentAssertions/Primitives/StringAssertions.cs Resolved
Comment thread Tests/Shared.Specs/StringAssertionSpecs.cs Resolved
Comment thread Tests/Shared.Specs/StringAssertionSpecs.cs Resolved
@danielmpetrov

danielmpetrov commented Sep 9, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for taking up this task!
I've only got a few things before everything looks good to me.
If any of my comments are unclear, don't hesitate asking.

Thanks for the review.

Since it's getting late now, I'll resolve these tomorrow and let you know.

dennisdoomen
dennisdoomen approved these changes Sep 10, 2019
View reviewed changes

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR. I have only one comment/concern.

Comment thread Tests/Shared.Specs/StringAssertionSpecs.cs Resolved
@jnyrup
jnyrup merged commit 7ba9252 into fluentassertions:master Sep 10, 2019
@danielmpetrov
danielmpetrov deleted the gh_997 branch September 11, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing StringAssertions::NotBeEquivalentTo

3 participants

@danielmpetrov @dennisdoomen @jnyrup