Visitar URL original
Added NotContainMatch method for string collections and unit tests to cover it by tomaustin700 · Pull Request #1246 · fluentassertions/fluentassertions · GitHub
Skip to content

Added NotContainMatch method for string collections and unit tests to cover it - #1246

Merged
dennisdoomen merged 3 commits into
fluentassertions:developfrom
tomaustin700:develop
Feb 10, 2020
Merged

Added NotContainMatch method for string collections and unit tests to cover it#1246
dennisdoomen merged 3 commits into
fluentassertions:developfrom
tomaustin700:develop

Conversation

@tomaustin700

@tomaustin700 tomaustin700 commented Feb 6, 2020

Copy link
Copy Markdown
Contributor

Added NotContainMatch for string collections which does the opposite of ContainMatch. I recently had a need for NotContainMatch so decided to add it.

dennisdoomen
dennisdoomen requested changes Feb 6, 2020
View reviewed changes

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also include the change in https://github.com/fluentassertions/fluentassertions/blob/develop/docs/_pages/releases.md

Comment thread FluentAssertions.sln Resolved
Comment thread Src/FluentAssertions/Collections/StringCollectionAssertions.cs Resolved
@dennisdoomen
dennisdoomen requested a review from jnyrup February 6, 2020 14:27
jnyrup
jnyrup requested changes Feb 6, 2020
View reviewed changes

@jnyrup jnyrup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good 👍
I'd like some tests covering the Which part of the return value.

Comment thread Src/FluentAssertions/Collections/StringCollectionAssertions.cs Resolved
Comment thread Src/FluentAssertions/Collections/StringCollectionAssertions.cs Resolved
@tomaustin700

tomaustin700 commented Feb 7, 2020

Copy link
Copy Markdown
Contributor Author

@dennisdoomen @jnyrup Thanks for the review, all issues should hopefully now be resolved.

@dennisdoomen
dennisdoomen requested a review from jnyrup February 8, 2020 13:17
jnyrup
jnyrup reviewed Feb 8, 2020
View reviewed changes
Comment thread Src/FluentAssertions/Collections/StringCollectionAssertions.cs Resolved
@tomaustin700
tomaustin700 requested a review from jnyrup February 10, 2020 09:24
@dennisdoomen
dennisdoomen merged commit a792813 into fluentassertions:develop Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomaustin700 @dennisdoomen @jnyrup