Visitar URL original
Allows using an IEqualityComparer<T> with BeEquivalentTo by dennisdoomen · Pull Request #1284 · fluentassertions/fluentassertions · GitHub
Skip to content

Allows using an IEqualityComparer<T> with BeEquivalentTo - #1284

Merged
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:Feature/IEqualityComparer
Mar 30, 2020
Merged

Allows using an IEqualityComparer<T> with BeEquivalentTo#1284
dennisdoomen merged 1 commit into
fluentassertions:developfrom
dennisdoomen:Feature/IEqualityComparer

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Mar 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

Adds overloads to the Using method of BeEquivalentTo options parameter to allows using an implementation of IEqualityComparer<T> as an alternative to IEquivalencyStep.

Resolves #1236

@dennisdoomen
dennisdoomen force-pushed the Feature/IEqualityComparer branch 2 times, most recently from 5d98982 to 81aa1d7 Compare March 29, 2020 15:27
jnyrup
jnyrup reviewed Mar 29, 2020
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/EqualityComparerEquivalencyStep.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/SelfReferenceEquivalencyAssertionOptions.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/EqualityComparerEquivalencyStep.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/EqualityComparerEquivalencyStep.cs Resolved
Comment thread docs/_pages/releases.md Resolved
@dennisdoomen
dennisdoomen force-pushed the Feature/IEqualityComparer branch 3 times, most recently from dcd1263 to 0b04d8a Compare March 29, 2020 17:33
@dennisdoomen
dennisdoomen requested a review from jnyrup March 29, 2020 17:33
jnyrup
jnyrup reviewed Mar 29, 2020
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/EqualityComparerEquivalencyStep.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the Feature/IEqualityComparer branch from 0b04d8a to f37fb98 Compare March 29, 2020 18:25
@dennisdoomen
dennisdoomen requested a review from jnyrup March 29, 2020 18:37
@jnyrup

jnyrup commented Mar 29, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

It would maybe be nice with a test hitting the UseRuntimeTypes case.

@dennisdoomen
dennisdoomen force-pushed the Feature/IEqualityComparer branch from f37fb98 to 2f7de4e Compare March 30, 2020 15:55
@dennisdoomen

dennisdoomen commented Mar 30, 2020

Copy link
Copy Markdown
Member Author

It would maybe be nice with a test hitting the UseRuntimeTypes case.

Because you insist ;-)

@jnyrup

jnyrup commented Mar 30, 2020

Copy link
Copy Markdown
Member

Woohoo!

@dennisdoomen
dennisdoomen merged commit c7ec7c6 into fluentassertions:develop Mar 30, 2020
@dennisdoomen
dennisdoomen deleted the Feature/IEqualityComparer branch March 30, 2020 16:26
@cz-dev-ge cz-dev-ge mentioned this pull request May 26, 2021
Closed
@jnyrup jnyrup mentioned this pull request Oct 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow using an IEqualityComparer in BeEquivalentTo

2 participants

@dennisdoomen @jnyrup