Visitar URL original
Ensure that chained assertion calls are ignored when the preceding one fails by dennisdoomen · Pull Request #1325 · fluentassertions/fluentassertions · GitHub
Skip to content

Ensure that chained assertion calls are ignored when the preceding one fails - #1325

Merged
dennisdoomen merged 4 commits into
fluentassertions:developfrom
dennisdoomen:Fix/ChainingApi
May 16, 2020
Merged

Ensure that chained assertion calls are ignored when the preceding one fails#1325
dennisdoomen merged 4 commits into
fluentassertions:developfrom
dennisdoomen:Fix/ChainingApi

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented May 9, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

When the initial assertion run through the AssertionScope failed, the chaining API would not ignore any following calls to Given, FailWith, etc.

Fixes #1302

  • Add release notes

@dennisdoomen
dennisdoomen force-pushed the Fix/ChainingApi branch 5 times, most recently from f4b455b to 22f39e3 Compare May 14, 2020 20:16
@dennisdoomen dennisdoomen changed the title Ensure that chained assertion calls are ignore when the preceeding one fails Ensure that chained assertion calls are ignored when the preceding one fails May 14, 2020
@dennisdoomen
dennisdoomen marked this pull request as ready for review May 14, 2020 20:17
@dennisdoomen
dennisdoomen requested a review from jnyrup May 14, 2020 20:17
@dennisdoomen
Grouped the AssertionScope specs in a functional matter.
7b0712a
@dennisdoomen
Blocks of comments are quite common while writing unit tests
0a0c921 
While practicing TDD, I often have a block of TODO comments listening the scenarios I think I need to cover. This should not cause compiler errors.
jnyrup
jnyrup reviewed May 16, 2020
View reviewed changes
Comment thread docs/_pages/releases.md Resolved
Comment thread Src/FluentAssertions/Execution/Continuation.cs Resolved
Comment thread Src/FluentAssertions/Execution/ContinuedAssertionScope.cs Resolved
Comment thread Src/FluentAssertions/Execution/ContinuedAssertionScope.cs Resolved
Comment thread Src/FluentAssertions/Execution/ContinuedAssertionScope.cs Resolved
Comment thread Src/FluentAssertions/Execution/GivenSelector.cs Resolved
Comment thread Src/FluentAssertions/Execution/GivenSelector.cs Resolved
Comment thread Src/FluentAssertions/Execution/ContinuedAssertionScope.cs Resolved
Comment thread Src/FluentAssertions/Execution/GivenSelector.cs Resolved
Comment thread docs/_pages/releases.md Resolved
@jnyrup

jnyrup commented May 16, 2020

Copy link
Copy Markdown
Member

Nice changes, and a breeze to review due to your diligent splitting of commits

@dennisdoomen
Chained givens and assertions were not honoring prior assertion results
23a654d 
When the initial assertion run through the AssertionScope failed, the chaining API would not ignore any following calls to Given, FailWith, etc.
@dennisdoomen
BeEquivalentTo does no longer throw an InvalidCastException while deb…
6c937a4 
…ugging
@dennisdoomen
dennisdoomen requested a review from jnyrup May 16, 2020 17:22
@dennisdoomen
dennisdoomen merged commit 0c1f83e into fluentassertions:develop May 16, 2020
@dennisdoomen
dennisdoomen deleted the Fix/ChainingApi branch May 16, 2020 20:06
@jnyrup jnyrup mentioned this pull request May 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InvalidCastException from EqualityComparerEquivalencyStep

2 participants

@dennisdoomen @jnyrup