Visitar URL original
Add NotCompleteWithinAsync to TaskCompletionSourceAssertions by lg2de · Pull Request #1474 · fluentassertions/fluentassertions · GitHub
Skip to content

Add NotCompleteWithinAsync to TaskCompletionSourceAssertions - #1474

Merged
jnyrup merged 1 commit into
fluentassertions:developfrom
lg2de:MissingNotCompletedAssertion
Jan 19, 2021
Merged

Add NotCompleteWithinAsync to TaskCompletionSourceAssertions#1474
jnyrup merged 1 commit into
fluentassertions:developfrom
lg2de:MissingNotCompletedAssertion

Conversation

@lg2de

@lg2de lg2de commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

The assertions on TaskCompletionSource introduced in #1267 was missing NotCompletedWithinAsync.

@lg2de
lg2de force-pushed the MissingNotCompletedAssertion branch from 5f5d0fa to 7a7e567 Compare January 18, 2021 16:13
jnyrup
jnyrup reviewed Jan 18, 2021
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskCompletionSourceAssertionSpecs.cs Resolved
@lg2de
lg2de force-pushed the MissingNotCompletedAssertion branch from 7a7e567 to ba4d6ac Compare January 18, 2021 19:31
dennisdoomen
dennisdoomen approved these changes Jan 19, 2021
View reviewed changes
Comment thread docs/_pages/releases.md Resolved
@lg2de
lg2de force-pushed the MissingNotCompletedAssertion branch from ba4d6ac to 5b15cc8 Compare January 19, 2021 08:51
@jnyrup
jnyrup merged commit 1214836 into fluentassertions:develop Jan 19, 2021
@lg2de
lg2de deleted the MissingNotCompletedAssertion branch January 19, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lg2de @dennisdoomen @jnyrup