Visitar URL original
Added milliseconds formatting by julian-code · Pull Request #1504 · fluentassertions/fluentassertions · GitHub
Skip to content

Added milliseconds formatting - #1504

Merged
dennisdoomen merged 2 commits into
fluentassertions:developfrom
julian-code:develop
Mar 5, 2021
Merged

Added milliseconds formatting#1504
dennisdoomen merged 2 commits into
fluentassertions:developfrom
julian-code:develop

Conversation

@julian-code

@julian-code julian-code commented Mar 4, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

Solves #1503

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by a new or existing set of unit tests which follow the Arrange-Act-Assert syntax such as is used in this example.
  • If the contribution adds a feature or fixes a bug, please update the release notes, which are published on the website.
  • If the contribution changes the public API the changes needs to be included by running AcceptApiChanges.ps1/AcceptApiChanges.sh.
  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.

dennisdoomen
dennisdoomen requested changes Mar 5, 2021
View reviewed changes

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Would you be willing to update the release notes as explained here

@julian-code

julian-code commented Mar 5, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Hey @dennisdoomen. I hope I did it right :-D.

Have a nice weekend.

@julian-code julian-code closed this Mar 5, 2021
@julian-code julian-code reopened this Mar 5, 2021
@julian-code

julian-code commented Mar 5, 2021

Copy link
Copy Markdown
Contributor Author

Ooops.

@julian-code
julian-code requested a review from dennisdoomen March 5, 2021 15:17
@dennisdoomen
dennisdoomen requested a review from jnyrup March 5, 2021 15:38
@dennisdoomen
dennisdoomen merged commit d628fd0 into fluentassertions:develop Mar 5, 2021
@jnyrup jnyrup linked an issue Mar 6, 2021 that may be closed by this pull request
Improve formatting of timespans #1503
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve formatting of timespans

3 participants

@julian-code @dennisdoomen @jnyrup