Visitar URL original
Added `ThrowWithinAsync` assertions by lg2de · Pull Request #1974 · fluentassertions/fluentassertions · GitHub
Skip to content

Added ThrowWithinAsync assertions - #1974

Merged
jnyrup merged 2 commits into
fluentassertions:developfrom
lg2de:throw-within
Mar 11, 2023
Merged

Added ThrowWithinAsync assertions#1974
jnyrup merged 2 commits into
fluentassertions:developfrom
lg2de:throw-within

Conversation

@lg2de

@lg2de lg2de commented Aug 17, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Any thoughts before I continue, @dennisdoomen, @jnyrup?

@jnyrup

jnyrup commented Aug 28, 2022

Copy link
Copy Markdown
Member

Sorry for the silence.
I would prefer to discuss new APIs in issues before heading to implementations as it makes it easier for us to only focus on the shape of the API and not the implementation details.
Please open an issue and if possible provide some thoughts/examples about the use cases.

This reminds me that I have to finish some documentation on the procress of proposing new APIs.
It will be heavily inspired by https://github.com/dotnet/runtime/blob/main/docs/project/api-review-process.md, but scaled down to a two-person OSS project.

@lg2de lg2de mentioned this pull request Nov 17, 2022
Closed
@coveralls

coveralls commented Dec 5, 2022 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 3623512252

Details

  • 31 of 33 (93.94%) changed or added relevant lines in 1 file are covered.
  • 18 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.847%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs 31 33 93.94%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs 7 92.4%
Src/FluentAssertions/Data/DataEquivalencyAssertionOptions.cs 11 86.73%
Totals Coverage Status
Change from base Build 3363358641: 0.2%
Covered Lines: 12462
Relevant Lines: 12713
💛 - Coveralls

@jnyrup jnyrup changed the title Added ThrowsWithinAsync assertions Added ThrowWithinAsync assertions Dec 5, 2022
@lg2de
lg2de force-pushed the throw-within branch 2 times, most recently from 3f6c983 to b7d37ef Compare December 7, 2022 18:45
lg2de
lg2de commented Dec 7, 2022
View reviewed changes
Comment thread Tests/Approval.Tests/ApprovedApi/FluentAssertions/net47.verified.txt Resolved
@lg2de

lg2de commented Dec 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Fixes #2034

@lg2de
lg2de marked this pull request as ready for review December 7, 2022 19:00
@jnyrup jnyrup added the feature label Dec 29, 2022
@dennisdoomen

dennisdoomen commented Jan 6, 2023

Copy link
Copy Markdown
Member

Now that the API is approved, I guess you can continue, right?

@lg2de

lg2de commented Jan 6, 2023

Copy link
Copy Markdown
Contributor Author

Now that the API is approved, I guess you can continue, right?

Yes, so far I did not have sufficient time.

@lg2de
lg2de marked this pull request as draft January 14, 2023 17:33
@lg2de
lg2de force-pushed the throw-within branch 2 times, most recently from b3c3867 to 69ee4f5 Compare January 14, 2023 17:51
@lg2de
lg2de marked this pull request as ready for review January 14, 2023 17:52
jnyrup
jnyrup reviewed Jan 14, 2023
View reviewed changes

@jnyrup jnyrup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, thanks!

Only a few comments about test coverage.

Comment thread Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs Resolved
Comment thread Src/FluentAssertions/Specialized/DelegateAssertionsBase.cs Resolved
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskAssertionSpecs.cs Resolved
jnyrup
jnyrup reviewed Jan 15, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs Resolved
@lg2de
lg2de force-pushed the throw-within branch 2 times, most recently from 091fadc to 9f1ff30 Compare January 15, 2023 15:54
jnyrup
jnyrup reviewed Jan 15, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs Resolved
jnyrup
jnyrup reviewed Jan 15, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Specialized/AsyncFunctionAssertions.cs Resolved
@lg2de
lg2de force-pushed the throw-within branch 2 times, most recently from ecad736 to 1e8d762 Compare January 16, 2023 08:25
jnyrup
jnyrup reviewed Jan 21, 2023
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskAssertionSpecs.cs Resolved
Comment thread Tests/FluentAssertions.Specs/Specialized/TaskAssertionSpecs.cs Resolved
@lg2de

lg2de commented Jan 21, 2023

Copy link
Copy Markdown
Contributor Author

Please note that I create my commits always to be merged without squashing.
If you disagree with my commits please drop me a note.

This was referenced Jun 1, 2026
Open
Closed
Merged
@dependabot dependabot Bot mentioned this pull request Jun 8, 2026
Open
This was referenced Jun 29, 2026
Merged
Open
This was referenced Aug 10, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Aug 21, 2026
Closed
This was referenced Aug 28, 2026
Closed
Closed
This was referenced Sep 17, 2026
Open
Open
This was referenced Sep 30, 2026
Closed
Closed
This was referenced Oct 12, 2026
Closed
Closed
This was referenced Oct 21, 2026
Closed
Closed
Open
This was referenced Nov 4, 2026
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 11, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes
+1 more reviewer
@IT-VBFK IT-VBFK IT-VBFK left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing ThrowWithinAsync similar to CompleteWithinAsync

6 participants

@lg2de @jnyrup @coveralls @dennisdoomen @julealgon @IT-VBFK