Visitar URL original
Qodana fixes by IT-VBFK · Pull Request #2221 · fluentassertions/fluentassertions · GitHub
Skip to content

Qodana fixes - #2221

Merged
dennisdoomen merged 11 commits into
fluentassertions:developfrom
IT-VBFK:quodana-fixes
Aug 17, 2023
Merged

Qodana fixes#2221
dennisdoomen merged 11 commits into
fluentassertions:developfrom
IT-VBFK:quodana-fixes

Conversation

@IT-VBFK

@IT-VBFK IT-VBFK commented Jun 13, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

First few Qodana "fixes".

Please close safely if it does not suit you :)

Note that I have most likely not covered all "same errors".

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@IT-VBFK
IT-VBFK force-pushed the quodana-fixes branch 4 times, most recently from ca683c5 to 675037b Compare June 13, 2023 19:34
jnyrup
jnyrup reviewed Jun 13, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/Tracing/Tracer.cs Resolved
@coveralls

coveralls commented Jun 13, 2023 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5717365346

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 4 (75.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 97.224%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/Formatting/DefaultValueFormatter.cs 0 1 0.0%
Totals Coverage Status
Change from base Build 5708086092: -0.007%
Covered Lines: 12903
Relevant Lines: 13146
💛 - Coveralls

@IT-VBFK

IT-VBFK commented Jun 13, 2023

Copy link
Copy Markdown
Contributor Author

Pretty sure that I would go straight to a closed institution after I am done here 😂

I also pretty sure that this is a never ending story ;)

jnyrup
jnyrup reviewed Jun 13, 2023
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Primitives/DateTimeOffsetAssertionSpecs.cs Resolved
Comment thread Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.cs Resolved
jnyrup
jnyrup reviewed Jun 14, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Common/MethodInfoExtensions.cs Resolved
Comment thread Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.cs Resolved
@IT-VBFK
IT-VBFK force-pushed the quodana-fixes branch 4 times, most recently from d4e6af6 to 028e0dc Compare June 14, 2023 15:48
dennisdoomen
dennisdoomen reviewed Jun 15, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Common/NullConfigurationStore.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Tracing/Tracer.cs Resolved
Comment thread Src/FluentAssertions/Execution/ContinuedAssertionScope.cs Resolved
@IT-VBFK

IT-VBFK commented Jun 15, 2023

Copy link
Copy Markdown
Contributor Author

To be honest... I'm in doubt whether this sort of changes have an end..

e.g. the latest Quodana run:
image

I am pretty sure that I have fixed less than 92 problems, but in return we have 92 new ones.

@dennisdoomen

dennisdoomen commented Jun 16, 2023

Copy link
Copy Markdown
Member

I am pretty sure that I have fixed less than 92 problems, but in return we have 92 new ones.

Because you touched old code ;-). But this requires tweaking. Not everything should be checked by Quodana.

@jnyrup jnyrup mentioned this pull request Jul 2, 2023
Merged
7 tasks
@IT-VBFK

IT-VBFK commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Hi

I will close this, because I am not that familiar with the whole codebase 🤔

But I stay attentively on this topic 🙃

@IT-VBFK IT-VBFK closed this Jul 31, 2023
@jnyrup

jnyrup commented Jul 31, 2023

Copy link
Copy Markdown
Member

Ohh... I liked this PR.
I only had some final comments before I was ready to merge it.

@IT-VBFK

IT-VBFK commented Jul 31, 2023

Copy link
Copy Markdown
Contributor Author

Oh.. in that case.. I will open it again 🫣

@IT-VBFK IT-VBFK reopened this Jul 31, 2023
jnyrup
jnyrup approved these changes Jul 31, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Common/NullConfigurationStore.cs Resolved
@jnyrup
jnyrup requested a review from dennisdoomen August 8, 2023 12:02
dennisdoomen
dennisdoomen requested changes Aug 12, 2023
View reviewed changes

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to disable the two rules (one only for the test projects).

Comment thread Src/FluentAssertions/Equivalency/Comparands.cs Resolved
Comment thread Tests/FluentAssertions.Specs/Primitives/DateTimeOffsetAssertionSpecs.cs Resolved
@dennisdoomen dennisdoomen changed the title Quodana fixes Qodana fixes Aug 12, 2023
@dennisdoomen

dennisdoomen commented Aug 13, 2023

Copy link
Copy Markdown
Member

It would be nice to use fix-up commits to remove those reversion commits from the PR

image

This was referenced Jun 2, 2026
Closed
Merged
Open
This was referenced Jun 29, 2026
Merged
Open
This was referenced Aug 10, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Aug 21, 2026
Closed
This was referenced Aug 28, 2026
Closed
Closed
Open
This was referenced Sep 17, 2026
Open
Open
This was referenced Sep 30, 2026
Closed
Closed
This was referenced Oct 12, 2026
Closed
Closed
This was referenced Oct 21, 2026
Closed
Closed
Open
This was referenced Nov 4, 2026
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 11, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes
+1 more reviewer
@Corniel Corniel Corniel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IT-VBFK @coveralls @dennisdoomen @jnyrup @Corniel