Visitar URL original
Fix qodana issues part 2 by IT-VBFK · Pull Request #2264 · fluentassertions/fluentassertions · GitHub
Skip to content

Fix qodana issues part 2 - #2264

Merged
dennisdoomen merged 10 commits into
fluentassertions:developfrom
IT-VBFK:fix/qodana-2
Aug 23, 2023
Merged

Fix qodana issues part 2#2264
dennisdoomen merged 10 commits into
fluentassertions:developfrom
IT-VBFK:fix/qodana-2

Conversation

@IT-VBFK

@IT-VBFK IT-VBFK commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@IT-VBFK
IT-VBFK force-pushed the fix/qodana-2 branch 2 times, most recently from adf6d64 to f030867 Compare August 17, 2023 16:34
@github-actions

github-actions Bot commented Aug 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@IT-VBFK
IT-VBFK force-pushed the fix/qodana-2 branch 3 times, most recently from 81881ce to 73d5b9a Compare August 17, 2023 16:42
jnyrup
jnyrup reviewed Aug 17, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Specialized/ExceptionAssertions.cs Resolved
Comment thread Src/FluentAssertions/Specialized/ExceptionAssertions.cs Resolved
@IT-VBFK
IT-VBFK force-pushed the fix/qodana-2 branch 4 times, most recently from 9c55da9 to 8a9d9a9 Compare August 17, 2023 17:26
@coveralls

coveralls commented Aug 17, 2023 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5929174797

  • 12 of 12 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.002%) to 97.236%
Totals Coverage Status
Change from base Build 5912924308: -0.002%
Covered Lines: 12942
Relevant Lines: 13185
💛 - Coveralls

@IT-VBFK

IT-VBFK commented Aug 18, 2023

Copy link
Copy Markdown
Contributor Author

image

Hä? I don't get it 😂😂

@jnyrup

jnyrup commented Aug 18, 2023

Copy link
Copy Markdown
Member

Try adding this to VB.Specs.vbproj

<RootNamespace>VB.Specs</RootNamespace>

@IT-VBFK
IT-VBFK force-pushed the fix/qodana-2 branch 6 times, most recently from a666e44 to 228097c Compare August 18, 2023 12:21
dennisdoomen
dennisdoomen reviewed Aug 19, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Formatting/PredicateLambdaExpressionValueFormatter.cs Resolved
Comment thread Src/FluentAssertions/Primitives/ObjectAssertions.cs Resolved
Comment thread Src/FluentAssertions/Specialized/ExecutionTimeAssertions.cs Resolved
Comment thread Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.cs Resolved
@IT-VBFK
IT-VBFK force-pushed the fix/qodana-2 branch 3 times, most recently from 7b3106b to 4eeccbb Compare August 19, 2023 18:46
jnyrup
jnyrup reviewed Aug 21, 2023
View reviewed changes
Comment thread Src/FluentAssertions/Formatting/PredicateLambdaExpressionValueFormatter.cs Resolved
Comment thread Src/FluentAssertions/Primitives/ObjectAssertions.cs Resolved
Comment thread Tests/FluentAssertions.Equivalency.Specs/SelectionRulesSpecs.cs Resolved
Comment thread Tests/VB.Specs/VB.Specs.vbproj Resolved
Comment thread Tests/FluentAssertions.Specs/Xml/XDocumentAssertionSpecs.cs Resolved
jnyrup
jnyrup reviewed Aug 21, 2023
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Xml/XDocumentAssertionSpecs.cs Resolved
This was referenced Jun 2, 2026
Closed
Merged
Open
This was referenced Jun 29, 2026
Merged
Open
This was referenced Aug 10, 2026
Closed
Closed
@dependabot dependabot Bot mentioned this pull request Aug 21, 2026
Closed
This was referenced Aug 28, 2026
Closed
Closed
Open
This was referenced Sep 17, 2026
Open
Open
This was referenced Sep 30, 2026
Closed
Closed
This was referenced Oct 12, 2026
Closed
Closed
This was referenced Oct 21, 2026
Closed
Closed
Open
This was referenced Nov 4, 2026
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Nov 11, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes
+1 more reviewer
@eNeRGy164 eNeRGy164 eNeRGy164 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@IT-VBFK @coveralls @jnyrup @dennisdoomen @eNeRGy164