Visitar URL original
Drop support for `NSpec3` by ITaluone · Pull Request #2356 · fluentassertions/fluentassertions · GitHub
Skip to content

Drop support for NSpec3 - #2356

Merged
dennisdoomen merged 3 commits into
fluentassertions:developfrom
ITaluone:clean/drop-nspec3
Oct 4, 2023
Merged

Drop support for NSpec3#2356
dennisdoomen merged 3 commits into
fluentassertions:developfrom
ITaluone:clean/drop-nspec3

Conversation

@ITaluone

@ITaluone ITaluone commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Closes: #2316

Review: ignore whitespace changes

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@ITaluone ITaluone changed the title Clean/drop nspec3 Drop NSpec3 support Oct 2, 2023
ITaluone
ITaluone commented Oct 2, 2023
View reviewed changes
Comment thread Tests/FluentAssertions.Specs/Execution/TestFrameworkProviderTests.cs Resolved
@github-actions

github-actions Bot commented Oct 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.6
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls

coveralls commented Oct 2, 2023 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 6384657777

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 97.342%
Totals Coverage Status
Change from base Build 6384600328: 0.04%
Covered Lines: 11619
Relevant Lines: 11817
💛 - Coveralls

ITaluone
ITaluone commented Oct 2, 2023
View reviewed changes
Comment thread Build/Build.cs Resolved
@ITaluone ITaluone changed the title Drop NSpec3 support Drop support for NSpec3 Oct 2, 2023
jnyrup
jnyrup reviewed Oct 2, 2023
View reviewed changes

@jnyrup jnyrup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Build/_build.csproj:21:    <PackageDownload Include="NSpec" Version="[3.1.0]" />
docs/_pages/about.md:56:* [NSpec](http://nspec.org/)
Src/FluentAssertions/FluentAssertions.csproj:29:    <PackageTags>MSTest2;xUnit;NUnit;MSpec;NSpec;TDD;BDD;Fluent;netstandard;uwp</PackageTags>

Comment thread Tests/FluentAssertions.Specs/Execution/TestFrameworkProviderTests.cs Resolved
Comment thread Build/Build.cs Resolved
@IT-VBFK

IT-VBFK commented Oct 2, 2023

Copy link
Copy Markdown
Contributor
image

Just to remember

@ITaluone
ITaluone requested a review from jnyrup October 3, 2023 07:21
@jnyrup
jnyrup requested a review from dennisdoomen October 3, 2023 07:25
@dennisdoomen
dennisdoomen merged commit c5b518a into fluentassertions:develop Oct 4, 2023
@ITaluone
ITaluone deleted the clean/drop-nspec3 branch October 4, 2023 05:42
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 1, 2026
Closed
Open
Open
Open
Open
Merged
Open
Open
Open
Closed
Open
Open
Open
This was referenced Nov 9, 2026
Open
Open
Open
Closed
Open
Open
Open
Closed
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop support for NSpec3

5 participants

@ITaluone @coveralls @IT-VBFK @dennisdoomen @jnyrup