Visitar URL original
Better support for default interface and explicitly implemented properties by dennisdoomen · Pull Request #2794 · fluentassertions/fluentassertions · GitHub
Skip to content

Better support for default interface and explicitly implemented properties - #2794

Merged
dennisdoomen merged 1 commit into
fluentassertions:masterfrom
dennisdoomen:fix/default-interface-property
Nov 8, 2024
Merged

Better support for default interface and explicitly implemented properties#2794
dennisdoomen merged 1 commit into
fluentassertions:masterfrom
dennisdoomen:fix/default-interface-property

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

Reimplemented the Reflection process using a content-only open-source library needed to find all types of properties and fields including default interface properties.

Fixes #2754 and #2759

@github-actions

github-actions Bot commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls

coveralls commented Oct 28, 2024 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 11739667739

Details

  • 40 of 41 (97.56%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 97.291%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/Equivalency/MemberVisibilityExtensions.cs 29 30 96.67%
Totals Coverage Status
Change from base Build 10774112131: -0.05%
Covered Lines: 12965
Relevant Lines: 13208
💛 - Coveralls

@dennisdoomen
dennisdoomen marked this pull request as ready for review October 28, 2024 21:16
@ITaluone

ITaluone commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

🤔 Missing release notes and/or documentation?

@ITaluone

ITaluone commented Oct 29, 2024

Copy link
Copy Markdown
Contributor

image

Do we really want this?

@dennisdoomen

dennisdoomen commented Oct 29, 2024

Copy link
Copy Markdown
Member Author

image

Do we really want this?

Nope. You're right. I need to fix that.

@dennisdoomen
dennisdoomen force-pushed the fix/default-interface-property branch from c81b709 to 51c118f Compare October 29, 2024 10:45
ITaluone
ITaluone reviewed Oct 29, 2024
View reviewed changes
Comment thread Build/Build.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the fix/default-interface-property branch 2 times, most recently from 503f625 to 73f5bd3 Compare October 29, 2024 16:45
jnyrup
jnyrup reviewed Nov 6, 2024
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/MemberVisibilityExtensions.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/MemberVisibilityExtensions.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the fix/default-interface-property branch from 73f5bd3 to bfaaec8 Compare November 8, 2024 09:01
@dennisdoomen
dennisdoomen force-pushed the fix/default-interface-property branch from bfaaec8 to f471413 Compare November 8, 2024 09:37
@dennisdoomen
dennisdoomen merged commit c6cd85c into fluentassertions:master Nov 8, 2024
@dennisdoomen
dennisdoomen deleted the fix/default-interface-property branch November 8, 2024 11:26
This was referenced Jul 21, 2025
Closed
Closed
Open
Closed
Closed
Closed
This was referenced Aug 3, 2025
Closed
Closed
Open
Closed
This was referenced Nov 1, 2026
Open
Open
Merged
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Closed
Closed
Open
This was referenced Nov 9, 2026
Closed
Closed
Closed
Closed
Closed
Open
Open
Closed
Closed
Closed
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes
+1 more reviewer
@ITaluone ITaluone ITaluone approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dennisdoomen @coveralls @ITaluone @jnyrup