Visitar URL original
Add section highlighting for better navigation by sentemon · Pull Request #2807 · fluentassertions/fluentassertions · GitHub
Skip to content

Add section highlighting for better navigation - #2807

Merged
dennisdoomen merged 2 commits into
fluentassertions:masterfrom
sentemon:feat/add-section-highlighting
Nov 9, 2024
Merged

dennisdoomen merged 2 commits into
fluentassertions:masterfrom
sentemon:feat/add-section-highlighting

Conversation

@sentemon

@sentemon sentemon commented Nov 8, 2024 •

Copy link
Copy Markdown
Contributor

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions

github-actions Bot commented Nov 8, 2024

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen

Copy link
Copy Markdown
Member

That looks pretty neat. Wouldn't it be nicer that if you select a section, only the relevant page is highlighted?

image

@sentemon

sentemon commented Nov 9, 2024

Copy link
Copy Markdown
Contributor Author

This means that the user is in the "Documentation" section, but if you select a specific section, only it will be highlighted
Screenshot 2024-11-09 at 10 22 13

@dennisdoomen

Copy link
Copy Markdown
Member

Isn't it nicer that then only the Documentation section is highlighted?

@sentemon

sentemon commented Nov 9, 2024

Copy link
Copy Markdown
Contributor Author

It seems to me that I did what you wanted, but honestly, I’m already tired of dealing with these styles - after all, I’m a backend developer, not a magician 😆

@github-actions

github-actions Bot commented Nov 9, 2024

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen

Copy link
Copy Markdown
Member

It seems to me that I did what you wanted, but honestly, I’m already tired of dealing with these styles - after all, I’m a backend developer, not a magician

Yeah, totally got that. Was just sharing some thoughts.

@dennisdoomen
dennisdoomen merged commit d4acc9d into fluentassertions:master Nov 9, 2024
@dennisdoomen

Copy link
Copy Markdown
Member

But thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants