Visitar URL original
Rollback Qodana version to solve a conflict with PolySharp by dennisdoomen · Pull Request #2889 · fluentassertions/fluentassertions · GitHub
Skip to content

Rollback Qodana version to solve a conflict with PolySharp - #2889

Merged
dennisdoomen merged 1 commit into
developfrom
dennisdoomen-patch-1
Dec 17, 2024
Merged

Rollback Qodana version to solve a conflict with PolySharp#2889
dennisdoomen merged 1 commit into
developfrom
dennisdoomen-patch-1

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Dec 17, 2024

Copy link
Copy Markdown
Member

The new version is having a conflict with PolySharp 1.15, so we need to rollback.

See also #2884

@github-actions

github-actions Bot commented Dec 17, 2024

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@github-actions

github-actions Bot commented Dec 17, 2024 •
edited
Loading

Copy link
Copy Markdown

Test Results

    36 files  ±0      36 suites  ±0   2m 35s ⏱️ +9s
 6 115 tests ±0   6 115 ✅ ±0  0 💤 ±0  0 ❌ ±0 
38 035 runs  ±0  38 035 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3407ef2. ± Comparison against base commit c050f6b.

This pull request removes 10 and adds 8 tests. Note that renamed tests count towards both. 
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
Object name: 'GetPositionExceptionMessage'.)

FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HaveLength ‑ When_a_throwing_stream_should_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+HavePosition ‑ When_a_throwing_stream_should_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHaveLength ‑ When_a_throwing_stream_should_not_have_a_length_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetLengthExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)
FluentAssertions.Specs.Streams.StreamAssertionSpecs+NotHavePosition ‑ When_a_throwing_stream_should_not_have_a_position_it_should_fail(exception: System.ObjectDisposedException: Cannot access a disposed object.
Object name: 'GetPositionExceptionMessage'.)

♻️ This comment has been updated with latest results.

@coveralls

coveralls commented Dec 17, 2024

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 12375837440

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.398%
Totals Coverage Status
Change from base Build 12359769115: 0.0%
Covered Lines: 12373
Relevant Lines: 12562
💛 - Coveralls

@dennisdoomen
dennisdoomen merged commit 87bc87b into develop Dec 17, 2024
@dennisdoomen
dennisdoomen deleted the dennisdoomen-patch-1 branch December 17, 2024 15:54
@jnyrup jnyrup mentioned this pull request Dec 18, 2024
Closed
@jnyrup jnyrup added the building Building and Infrastructure of Fluent Assertions label Dec 27, 2024
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Jul 29, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 3, 2026
Closed
Merged
Open
Open
Open
Open
Open
Open
Closed
Open
Open
Open
Closed
Closed
Closed
This was referenced Nov 11, 2026
Open
Closed
Closed
Closed
Open
Closed
Closed
Open
Open
Closed
Open
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dennisdoomen @coveralls @jnyrup