Visitar URL original
Revisit the .editorconfig rules by dennisdoomen · Pull Request #3063 · fluentassertions/fluentassertions · GitHub
Skip to content

Revisit the .editorconfig rules - #3063

Merged
dennisdoomen merged 3 commits into
fluentassertions:mainfrom
dennisdoomen:refactor/cleanup-editor-config
Jun 29, 2025
Merged

Revisit the .editorconfig rules#3063
dennisdoomen merged 3 commits into
fluentassertions:mainfrom
dennisdoomen:refactor/cleanup-editor-config

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Jun 22, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Triggered by dennisdoomen/dotnet-library-starter-kit#31, I decided to revisit the .editorconfig and use it in FA as well. This triggered a bunch of improvements and fine-tuning.

Can be reviewed commit by commit.

@github-actions

github-actions Bot commented Jun 22, 2025 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen
dennisdoomen force-pushed the refactor/cleanup-editor-config branch 5 times, most recently from 026be7d to 8755893 Compare June 23, 2025 18:05
@coveralls

coveralls commented Jun 23, 2025 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 15954300159

Details

  • 125 of 128 (97.66%) changed or added relevant lines in 25 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.004%) to 97.323%
Changes Missing Coverage Covered Lines Changed/Added Lines %
Src/FluentAssertions/CallerIdentifier.cs 1 2 50.0%
Src/FluentAssertions/Common/KeyValuePairCollectionExtensions.cs 10 12 83.33%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Equivalency/Steps/EnumEqualityStep.cs 1 97.5%
Src/FluentAssertions/Execution/TUnitFramework.cs 1 80.0%
Totals Coverage Status
Change from base Build 15843385706: 0.004%
Covered Lines: 12504
Relevant Lines: 12703
💛 - Coveralls

jnyrup
jnyrup reviewed Jun 24, 2025
View reviewed changes
Comment thread Src/FluentAssertions/CallerIdentifier.cs Resolved
Comment thread Tests/.editorconfig Resolved
Comment thread Src/FluentAssertions/Primitives/StringAssertions.cs Resolved
Comment thread Src/FluentAssertions/Collections/GenericDictionaryAssertions.cs Resolved
Comment thread Src/FluentAssertions/Common/TypeExtensions.cs Resolved
Comment thread Src/FluentAssertions/Execution/LateBoundTestFramework.cs Resolved
Comment thread Src/FluentAssertions/Primitives/StringAssertions.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Execution/ObjectReference.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Execution/ObjectReference.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the refactor/cleanup-editor-config branch 2 times, most recently from bb204da to 83fda36 Compare June 26, 2025 19:48
@dennisdoomen

dennisdoomen commented Jun 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Member Author

@jnyrup I didn't make any changes other than rework on your comments, but I tried to split the modifications in a bunch of commits for clarity.

@dennisdoomen
dennisdoomen requested a review from jnyrup June 26, 2025 19:49
@dennisdoomen
dennisdoomen marked this pull request as ready for review June 26, 2025 19:50
@dennisdoomen
dennisdoomen force-pushed the refactor/cleanup-editor-config branch from 83fda36 to fbc5579 Compare June 27, 2025 07:51
jnyrup
jnyrup reviewed Jun 27, 2025
View reviewed changes

@jnyrup jnyrup left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes!

I often look in analyzer suggestions and it's now flooded with suggestions that are currently disabled.
Could we keep those disabled if we don't care about them?

AV1551
AV1706
AV2305
SA1615
SA1623

Comment thread Src/FluentAssertions/Collections/GenericDictionaryAssertions.cs Resolved
Comment thread Src/FluentAssertions/Collections/GenericDictionaryAssertions.cs Resolved
Comment thread Src/FluentAssertions/Primitives/StringAssertions.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Execution/ObjectReference.cs Resolved
Comment thread Src/FluentAssertions/Execution/LateBoundTestFramework.cs Resolved
Comment thread Src/FluentAssertions/Common/KeyValuePairCollectionExtensions.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Execution/ObjectReference.cs Resolved
@dennisdoomen
dennisdoomen requested a review from jnyrup June 27, 2025 20:14
@dennisdoomen
dennisdoomen force-pushed the refactor/cleanup-editor-config branch 2 times, most recently from bb204da to cb7f318 Compare June 29, 2025 10:34
@dennisdoomen
dennisdoomen merged commit 7cb0838 into fluentassertions:main Jun 29, 2025
@dennisdoomen
dennisdoomen deleted the refactor/cleanup-editor-config branch July 20, 2025 07:34
This was referenced Jul 22, 2025
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Nov 2, 2026
Open
Merged
Closed
Open
Merged
Closed
Merged
Open
Open
This was referenced Nov 9, 2026
Closed
Open
Open
Open
Open
Open
Closed
Open
Open
Closed
Closed
Closed
Merged
Open
Closed
Closed
Closed
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dennisdoomen @coveralls @jnyrup