Visitar URL original
Ensured WithTracing is safe when used with BeEquivalentTo globally by dennisdoomen · Pull Request #3067 · fluentassertions/fluentassertions · GitHub
Skip to content

Ensured WithTracing is safe when used with BeEquivalentTo globally - #3067

Merged
dennisdoomen merged 1 commit into
fluentassertions:mainfrom
dennisdoomen:fix/tracing-concurrency
Jul 2, 2025
Merged

Ensured WithTracing is safe when used with BeEquivalentTo globally#3067
dennisdoomen merged 1 commit into
fluentassertions:mainfrom
dennisdoomen:fix/tracing-concurrency

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Jun 29, 2025

Copy link
Copy Markdown
Member

Solves #2619

@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch from 7965d9c to 74b65e7 Compare June 29, 2025 07:30
@dennisdoomen
dennisdoomen requested a review from Copilot June 29, 2025 07:30
Copilot AI reviewed Jun 29, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR ensures that WithTracing is safe when used with BeEquivalentTo globally. It updates the release notes, adds a test to validate concurrent tracing behavior, and refactors the trace writer to be thread safe by using AsyncLocal.

  • Updated release notes to include version 8.5.0 and related fixes/enhancements.
  • Added a concurrent execution test in TracingSpecs to validate tracing safety.
  • Refactored StringBuilderTraceWriter to use AsyncLocal for thread safety.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/_pages/releases.md Updated release notes with version 8.5.0 fixes and enhancements.
Tests/FluentAssertions.Equivalency.Specs/TracingSpecs.cs Added a new test to ensure WithTracing works safely under concurrent conditions.
Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Refactored thread unsafe code by replacing direct state management with AsyncLocal.

Comment thread Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch from 74b65e7 to 645df6d Compare June 29, 2025 07:35
@dennisdoomen
dennisdoomen marked this pull request as ready for review June 29, 2025 07:35
@dennisdoomen
dennisdoomen requested a review from jnyrup June 29, 2025 07:35
@github-actions

github-actions Bot commented Jun 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen
dennisdoomen removed the request for review from jnyrup June 29, 2025 07:58
@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch from 645df6d to 017d4d7 Compare June 29, 2025 09:48
@coveralls

coveralls commented Jun 29, 2025 •
edited
Loading

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 16028431685

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 97.309%
Totals Coverage Status
Change from base Build 15982317140: 0.001%
Covered Lines: 12545
Relevant Lines: 12745
💛 - Coveralls

jnyrup
jnyrup reviewed Jun 29, 2025
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Resolved
jnyrup
jnyrup reviewed Jun 29, 2025
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch 4 times, most recently from 93d7291 to e8df814 Compare June 29, 2025 17:26
jnyrup
jnyrup reviewed Jun 30, 2025
View reviewed changes
Comment thread Src/FluentAssertions/Equivalency/Tracing/StringBuilderTraceWriter.cs Resolved
Comment thread Src/FluentAssertions/Equivalency/EquivalencyValidationContext.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch 2 times, most recently from 6283f6d to 5f07848 Compare July 1, 2025 21:06
@dennisdoomen
dennisdoomen requested a review from jnyrup July 1, 2025 21:06
jnyrup
jnyrup reviewed Jul 2, 2025
View reviewed changes
Comment thread Tests/FluentAssertions.Equivalency.Specs/DictionarySpecs.cs Resolved
@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch from 5f07848 to 3b21037 Compare July 2, 2025 14:29
@dennisdoomen
dennisdoomen requested a review from jnyrup July 2, 2025 14:29
@dennisdoomen
dennisdoomen force-pushed the fix/tracing-concurrency branch from 3b21037 to 6e4adc3 Compare July 2, 2025 14:49
@dennisdoomen
dennisdoomen merged commit 9678cd6 into fluentassertions:main Jul 2, 2025
@dennisdoomen
dennisdoomen deleted the fix/tracing-concurrency branch July 2, 2025 15:09
@dependabot dependabot Bot mentioned this pull request Jul 22, 2025
Closed
This was referenced Oct 29, 2026
Open
Open
Open
Open
Open
Merged
Merged
Open
Merged
Closed
Closed
Closed
Merged
Open
Open
Open
This was referenced Nov 9, 2026
Closed
Open
Closed
Closed
Closed
Closed
Closed
Closed
Open
Closed
Open
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

8.5.0

Development

Successfully merging this pull request may close these issues.

4 participants

@dennisdoomen @coveralls @jnyrup