Visitar URL original
Add lock file for nuget packages by jnyrup · Pull Request #3084 · fluentassertions/fluentassertions · GitHub
Skip to content

Add lock file for nuget packages - #3084

Merged
jnyrup merged 1 commit into
fluentassertions:mainfrom
jnyrup:lock_file
Sep 9, 2025
Merged

jnyrup merged 1 commit into
fluentassertions:mainfrom
jnyrup:lock_file

Conversation

@jnyrup

@jnyrup jnyrup commented Aug 17, 2025

Copy link
Copy Markdown
Member

This PR adds a lock file and enforces it to be used when restoring nuget packages in a CI pipeline.
This gives more visibility about what packages change when a package reference is changed.

https://devblogs.microsoft.com/dotnet/enable-repeatable-package-restores-using-a-lock-file/

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

CONTRIBUTOR LICENSE GRANT

By submitting this contribution, the contributor hereby irrevocably grants to the project owners and maintainers a perpetual, worldwide, royalty-free, irrevocable license to use, reproduce, modify, distribute, sublicense, and create derivative works of the contribution for any purpose and under any terms, including proprietary licensing.

The contributor waives any moral rights in the contribution to the extent permitted by law and agrees not to assert any claim of authorship or control over the contribution. The contributor represents that they are the sole author of the contribution and that it is provided free of any third-party claims.

The contributor understands and agrees that the maintainers may, at their sole discretion, use, license, or redistribute the contribution as part of any work and under any terms they choose, without further permission or attribution.

  • I have read the Contributor License Grant and accept the conditions
  • I'm interested in a free license for Fluent Assertions and will share my email address through sales@xceed.com

@jnyrup jnyrup added the building Building and Infrastructure of Fluent Assertions label Aug 17, 2025
@coveralls

coveralls commented Aug 17, 2025 •

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17555116351

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.292%

Totals Coverage Status
Change from base Build 17402045285: 0.0%
Covered Lines: 12572
Relevant Lines: 12774

💛 - Coveralls

@github-actions

github-actions Bot commented Aug 17, 2025 •

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen dennisdoomen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@jnyrup
jnyrup force-pushed the lock_file branch 4 times, most recently from b0b94fd to 91baa42 Compare August 18, 2025 15:09
@dennisdoomen

Copy link
Copy Markdown
Member

@jnyrup any reason why you haven't merged this one yet?

@jnyrup

jnyrup commented Sep 7, 2025

Copy link
Copy Markdown
Member Author

Yes, wanted to double check that if the nuget restore tried to use another package than specified in the lock file, it should fail.

@github-actions

github-actions Bot commented Sep 8, 2025 •

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jnyrup

jnyrup commented Sep 8, 2025

Copy link
Copy Markdown
Member Author

Finally got it to work.
Here's the output If I update Meziantou.Analyzer without updating the lockfile.

image

This was referenced Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

building Building and Infrastructure of Fluent Assertions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants