Visitar URL original
Simplify GetMinValue/GetMaxValue by jnyrup · Pull Request #3210 · fluentassertions/fluentassertions · GitHub
Skip to content

Simplify GetMinValue/GetMaxValue - #3210

Merged
jnyrup merged 1 commit into
fluentassertions:mainfrom
jnyrup:overflow_improvements
May 12, 2026
Merged

jnyrup merged 1 commit into
fluentassertions:mainfrom
jnyrup:overflow_improvements

Conversation

@jnyrup

@jnyrup jnyrup commented May 12, 2026

Copy link
Copy Markdown
Member

Try fixing Qodana report about potential overflow.
We have quite a few tests in NumericAssertionSpecs.BeCloseTo.cs but this code is easier to reason about and it's not a hot path.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

CONTRIBUTOR LICENSE GRANT

By submitting this contribution, the contributor hereby irrevocably grants to the project owners and maintainers a perpetual, worldwide, royalty-free, irrevocable license to use, reproduce, modify, distribute, sublicense, and create derivative works of the contribution for any purpose and under any terms, including proprietary licensing.

The contributor waives any moral rights in the contribution to the extent permitted by law and agrees not to assert any claim of authorship or control over the contribution. The contributor represents that they are the sole author of the contribution and that it is provided free of any third-party claims.

The contributor understands and agrees that the maintainers may, at their sole discretion, use, license, or redistribute the contribution as part of any work and under any terms they choose, without further permission or attribution.

  • I have read the Contributor License Grant and accept the conditions
  • I'm interested in a free license for Fluent Assertions and will share my email address through sales@xceed.com

@github-actions

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jnyrup
jnyrup requested a review from dennisdoomen May 12, 2026 13:59
@jnyrup
jnyrup merged commit 78b75f6 into fluentassertions:main May 12, 2026
8 checks passed
@jnyrup
jnyrup deleted the overflow_improvements branch May 13, 2026 08:02
This was referenced Sep 14, 2026
This was referenced Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants