Visitar URL original
JsonNodeAssertions.BeNumeric/NotBeNumeric no longer throw on manually constructed JsonNode by jeremy-morren · Pull Request #3354 · fluentassertions/fluentassertions · GitHub
Skip to content

JsonNodeAssertions.BeNumeric/NotBeNumeric no longer throw on manually constructed JsonNode - #3354

Merged
dennisdoomen merged 1 commit into
fluentassertions:mainfrom
jeremy-morren:main
Sep 29, 2026
Merged

dennisdoomen merged 1 commit into
fluentassertions:mainfrom
jeremy-morren:main

Conversation

@jeremy-morren

@jeremy-morren jeremy-morren commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #3353

  • JsonValueExtensions.IsNumeric() now handles the case where JsonNode was manually constructed.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

CONTRIBUTOR LICENSE GRANT

By submitting this contribution, the contributor hereby irrevocably grants to the project owners and maintainers a perpetual, worldwide, royalty-free, irrevocable license to use, reproduce, modify, distribute, sublicense, and create derivative works of the contribution for any purpose and under any terms, including proprietary licensing.

The contributor waives any moral rights in the contribution to the extent permitted by law and agrees not to assert any claim of authorship or control over the contribution. The contributor represents that they are the sole author of the contribution and that it is provided free of any third-party claims.

The contributor understands and agrees that the maintainers may, at their sole discretion, use, license, or redistribute the contribution as part of any work and under any terms they choose, without further permission or attribution.

  • I have read the Contributor License Grant and accept the conditions
  • I'm interested in a free license for Fluent Assertions and will share my email address through sales@xceed.com

Comment thread docs/_pages/releases.md Resolved
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Comment thread docs/_pages/releases.md Resolved
@jeremy-morren

Copy link
Copy Markdown
Contributor Author

Rebased onto main and squashed commits as requested.

@jeremy-morren

Copy link
Copy Markdown
Contributor Author

Rebased onto main as requested and squashed to a single commit. Please let me know if any other changes are required.

…values.

* Fixes fluentassertions#3353
* Added .NET 8 implementation of IsNumeric() for future reference
@dennisdoomen dennisdoomen changed the title Updated JsonNode.IsNumeric() to handle manually constructed JsonNode values JsonNodeAssertions.BeNumeric/NotBeNumeric no longer throw on manually constructed JsonNode Sep 29, 2026
@dennisdoomen
dennisdoomen enabled auto-merge (rebase) September 29, 2026 05:07
@dennisdoomen
dennisdoomen merged commit 8d60434 into fluentassertions:main Sep 29, 2026
8 checks passed

This branch was previously deployed

1 inactive deployment
qodana-pr — 9ec13de0 Deployed Sep 29, 2026 by jeremy-morren via Qodana Scan #192
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BeNumeric exception on certain JsonNode values

3 participants