Visitar URL original
Add `BeApproximately` version for both subject and expected nullable by krajek · Pull Request #934 · fluentassertions/fluentassertions · GitHub
Skip to content

Add BeApproximately version for both subject and expected nullable - #934

Merged
jnyrup merged 3 commits into
fluentassertions:masterfrom
krajek:expected_numeric_nullable
Oct 2, 2018
Merged

Add BeApproximately version for both subject and expected nullable#934
jnyrup merged 3 commits into
fluentassertions:masterfrom
krajek:expected_numeric_nullable

Conversation

@krajek

@krajek krajek commented Oct 1, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Closes #922.

For now, I have tackled only the case of double?.
Please review. Upon approval, I will copy the logic and tests for float? and decimal?.

@krajek krajek changed the title [WIP]Add BeApproximately for both subject and expected of type double? [WIP] Add BeApproximately version for both subject and expected nullable Oct 1, 2018
@krajek
krajek force-pushed the expected_numeric_nullable branch from 804f688 to 3f33cc2 Compare October 2, 2018 06:41
@krajek
krajek force-pushed the expected_numeric_nullable branch from 675c41f to 612a1e3 Compare October 2, 2018 18:13
@krajek krajek changed the title [WIP] Add BeApproximately version for both subject and expected nullable Add BeApproximately version for both subject and expected nullable Oct 2, 2018
@krajek

krajek commented Oct 2, 2018

Copy link
Copy Markdown
Contributor Author

PR is ready.
Let me know what you think about NotBeApproximately(nullable, nullable[...]).
For me it makes sense, but it was not discussed not requested in the #922.
I will create another PR if we agree to add it.

@jnyrup
jnyrup merged commit 42ef7d9 into fluentassertions:master Oct 2, 2018
@jnyrup

jnyrup commented Oct 2, 2018

Copy link
Copy Markdown
Member

@krajek to quote an incredible active contributor (hint, it's you!)

Good catch, thanks.

I didn't think about NotBeApproximately, but it makes good sense to add that as well the align the API overloads with BeApproximately.

@dennisdoomen

dennisdoomen commented Oct 3, 2018

Copy link
Copy Markdown
Member

Yeah, I wonder where @krajek is getting the time from.... ;-)

@krajek
krajek deleted the expected_numeric_nullable branch October 3, 2018 05:12
This was referenced Oct 3, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes
@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@krajek @jnyrup @dennisdoomen