Visitar URL original
Add leak tracking in test/painting #1 by droidbg · Pull Request #136167 · flutter/flutter · GitHub
Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor. remove formatting border_test.dart
  • Loading branch information
droidbg committed Oct 9, 2023
commit abbf1b5dad05506b8ae45c817d5efffd6a42a531
197 changes: 65 additions & 132 deletions packages/flutter/test/painting/border_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,10 @@ void main() {
});

test('Border.merge', () {
const BorderSide magenta3 =
BorderSide(color: Color(0xFFFF00FF), width: 3.0);
const BorderSide magenta6 =
BorderSide(color: Color(0xFFFF00FF), width: 6.0);
const BorderSide magenta3 = BorderSide(color: Color(0xFFFF00FF), width: 3.0);
const BorderSide magenta6 = BorderSide(color: Color(0xFFFF00FF), width: 6.0);
const BorderSide yellow2 = BorderSide(color: Color(0xFFFFFF00), width: 2.0);
const BorderSide yellowNone0 = BorderSide(
color: Color(0xFFFFFF00), width: 0.0, style: BorderStyle.none);
const BorderSide yellowNone0 = BorderSide(color: Color(0xFFFFFF00), width: 0.0, style: BorderStyle.none);
expect(
Border.merge(
const Border(top: yellow2),
Expand All @@ -69,7 +66,7 @@ void main() {
const Border(),
);
expect(
() => Border.merge(
() => Border.merge(
const Border(left: magenta3),
const Border(left: yellow2),
),
Expand All @@ -78,13 +75,10 @@ void main() {
});

test('Border.add', () {
const BorderSide magenta3 =
BorderSide(color: Color(0xFFFF00FF), width: 3.0);
const BorderSide magenta6 =
BorderSide(color: Color(0xFFFF00FF), width: 6.0);
const BorderSide magenta3 = BorderSide(color: Color(0xFFFF00FF), width: 3.0);
const BorderSide magenta6 = BorderSide(color: Color(0xFFFF00FF), width: 6.0);
const BorderSide yellow2 = BorderSide(color: Color(0xFFFFFF00), width: 2.0);
const BorderSide yellowNone0 = BorderSide(
color: Color(0xFFFFFF00), width: 0.0, style: BorderStyle.none);
const BorderSide yellowNone0 = BorderSide(color: Color(0xFFFFFF00), width: 0.0, style: BorderStyle.none);
expect(
const Border(top: yellow2) + const Border(right: magenta3),
const Border(top: yellow2, right: magenta3),
Expand All @@ -94,8 +88,7 @@ void main() {
const Border(bottom: magenta6),
);
expect(
const Border(left: magenta3, right: yellowNone0) +
const Border(right: yellow2),
const Border(left: magenta3, right: yellowNone0) + const Border(right: yellow2),
const Border(left: magenta3, right: yellow2),
);
expect(
Expand All @@ -104,8 +97,7 @@ void main() {
);
expect(
const Border(left: magenta3) + const Border(left: yellow2),
isNot(isA<
Border>()), // see shape_border_test.dart for better tests of this case
isNot(isA<Border>()), // see shape_border_test.dart for better tests of this case
);
const Border b3 = Border(top: magenta3);
const Border b6 = Border(top: magenta6);
Expand All @@ -119,13 +111,10 @@ void main() {
});

test('Border.scale', () {
const BorderSide magenta3 =
BorderSide(color: Color(0xFFFF00FF), width: 3.0);
const BorderSide magenta6 =
BorderSide(color: Color(0xFFFF00FF), width: 6.0);
const BorderSide magenta3 = BorderSide(color: Color(0xFFFF00FF), width: 3.0);
const BorderSide magenta6 = BorderSide(color: Color(0xFFFF00FF), width: 6.0);
const BorderSide yellow2 = BorderSide(color: Color(0xFFFFFF00), width: 2.0);
const BorderSide yellowNone0 = BorderSide(
color: Color(0xFFFFFF00), width: 0.0, style: BorderStyle.none);
const BorderSide yellowNone0 = BorderSide(color: Color(0xFFFFFF00), width: 0.0, style: BorderStyle.none);
const Border b3 = Border(left: magenta3);
const Border b6 = Border(left: magenta6);
expect(b3.scale(2.0), b6);
Expand Down Expand Up @@ -230,55 +219,41 @@ void main() {

test('Border.lerp', () {
const Border visualWithTop10 = Border(top: BorderSide(width: 10.0));
const Border atMinus100 =
Border(left: BorderSide(width: 0.0), right: BorderSide(width: 300.0));
const Border at0 =
Border(left: BorderSide(width: 100.0), right: BorderSide(width: 200.0));
const Border at25 =
Border(left: BorderSide(width: 125.0), right: BorderSide(width: 175.0));
const Border at75 =
Border(left: BorderSide(width: 175.0), right: BorderSide(width: 125.0));
const Border at100 =
Border(left: BorderSide(width: 200.0), right: BorderSide(width: 100.0));
const Border at200 =
Border(left: BorderSide(width: 300.0), right: BorderSide(width: 0.0));
const Border atMinus100 = Border(left: BorderSide(width: 0.0), right: BorderSide(width: 300.0));
const Border at0 = Border(left: BorderSide(width: 100.0), right: BorderSide(width: 200.0));
const Border at25 = Border(left: BorderSide(width: 125.0), right: BorderSide(width: 175.0));
const Border at75 = Border(left: BorderSide(width: 175.0), right: BorderSide(width: 125.0));
const Border at100 = Border(left: BorderSide(width: 200.0), right: BorderSide(width: 100.0));
const Border at200 = Border(left: BorderSide(width: 300.0), right: BorderSide(width: 0.0));

expect(Border.lerp(null, null, -1.0), null);
expect(Border.lerp(visualWithTop10, null, -1.0),
const Border(top: BorderSide(width: 20.0)));
expect(Border.lerp(visualWithTop10, null, -1.0), const Border(top: BorderSide(width: 20.0)));
expect(Border.lerp(null, visualWithTop10, -1.0), const Border());
expect(Border.lerp(at0, at100, -1.0), atMinus100);

expect(Border.lerp(null, null, 0.0), null);
expect(Border.lerp(visualWithTop10, null, 0.0),
const Border(top: BorderSide(width: 10.0)));
expect(Border.lerp(visualWithTop10, null, 0.0), const Border(top: BorderSide(width: 10.0)));
expect(Border.lerp(null, visualWithTop10, 0.0), const Border());
expect(Border.lerp(at0, at100, 0.0), at0);

expect(Border.lerp(null, null, 0.25), null);
expect(Border.lerp(visualWithTop10, null, 0.25),
const Border(top: BorderSide(width: 7.5)));
expect(Border.lerp(null, visualWithTop10, 0.25),
const Border(top: BorderSide(width: 2.5)));
expect(Border.lerp(visualWithTop10, null, 0.25), const Border(top: BorderSide(width: 7.5)));
expect(Border.lerp(null, visualWithTop10, 0.25), const Border(top: BorderSide(width: 2.5)));
expect(Border.lerp(at0, at100, 0.25), at25);

expect(Border.lerp(null, null, 0.75), null);
expect(Border.lerp(visualWithTop10, null, 0.75),
const Border(top: BorderSide(width: 2.5)));
expect(Border.lerp(null, visualWithTop10, 0.75),
const Border(top: BorderSide(width: 7.5)));
expect(Border.lerp(visualWithTop10, null, 0.75), const Border(top: BorderSide(width: 2.5)));
expect(Border.lerp(null, visualWithTop10, 0.75), const Border(top: BorderSide(width: 7.5)));
expect(Border.lerp(at0, at100, 0.75), at75);

expect(Border.lerp(null, null, 1.0), null);
expect(Border.lerp(visualWithTop10, null, 1.0), const Border());
expect(Border.lerp(null, visualWithTop10, 1.0),
const Border(top: BorderSide(width: 10.0)));
expect(Border.lerp(null, visualWithTop10, 1.0), const Border(top: BorderSide(width: 10.0)));
expect(Border.lerp(at0, at100, 1.0), at100);

expect(Border.lerp(null, null, 2.0), null);
expect(Border.lerp(visualWithTop10, null, 2.0), const Border());
expect(Border.lerp(null, visualWithTop10, 2.0),
const Border(top: BorderSide(width: 20.0)));
expect(Border.lerp(null, visualWithTop10, 2.0), const Border(top: BorderSide(width: 20.0)));
expect(Border.lerp(at0, at100, 2.0), at200);
});

Expand All @@ -289,12 +264,8 @@ void main() {
// Border.all supports all StrokeAlign values.
// Border() supports [BorderSide.strokeAlignInside] only.
const Border(
left: BorderSide(
strokeAlign: BorderSide.strokeAlignCenter,
color: Color(0xff000001)),
right: BorderSide(
strokeAlign: BorderSide.strokeAlignOutside,
color: Color(0xff000002)),
left: BorderSide(strokeAlign: BorderSide.strokeAlignCenter, color: Color(0xff000001)),
right: BorderSide(strokeAlign: BorderSide.strokeAlignOutside, color: Color(0xff000002)),
).paint(canvas, const Rect.fromLTWH(10.0, 20.0, 30.0, 40.0));
} on FlutterError catch (e) {
error = e;
Expand All @@ -311,40 +282,22 @@ void main() {
final Border insideBorder = Border.all(width: 10);
expect(insideBorder.dimensions, const EdgeInsets.all(10));

final Border centerBorder =
Border.all(width: 10, strokeAlign: BorderSide.strokeAlignCenter);
final Border centerBorder = Border.all(width: 10, strokeAlign: BorderSide.strokeAlignCenter);
expect(centerBorder.dimensions, const EdgeInsets.all(5));

final Border outsideBorder =
Border.all(width: 10, strokeAlign: BorderSide.strokeAlignOutside);
final Border outsideBorder = Border.all(width: 10, strokeAlign: BorderSide.strokeAlignOutside);
expect(outsideBorder.dimensions, EdgeInsets.zero);

const BorderSide insideSide = BorderSide(width: 10);
const BorderDirectional insideBorderDirectional = BorderDirectional(
top: insideSide,
bottom: insideSide,
start: insideSide,
end: insideSide);
expect(insideBorderDirectional.dimensions,
const EdgeInsetsDirectional.all(10));

const BorderSide centerSide =
BorderSide(width: 10, strokeAlign: BorderSide.strokeAlignCenter);
const BorderDirectional centerBorderDirectional = BorderDirectional(
top: centerSide,
bottom: centerSide,
start: centerSide,
end: centerSide);
expect(
centerBorderDirectional.dimensions, const EdgeInsetsDirectional.all(5));

const BorderSide outsideSide =
BorderSide(width: 10, strokeAlign: BorderSide.strokeAlignOutside);
const BorderDirectional outsideBorderDirectional = BorderDirectional(
top: outsideSide,
bottom: outsideSide,
start: outsideSide,
end: outsideSide);
const BorderDirectional insideBorderDirectional = BorderDirectional(top: insideSide, bottom: insideSide, start: insideSide, end: insideSide);
expect(insideBorderDirectional.dimensions, const EdgeInsetsDirectional.all(10));

const BorderSide centerSide = BorderSide(width: 10, strokeAlign: BorderSide.strokeAlignCenter);
const BorderDirectional centerBorderDirectional = BorderDirectional(top: centerSide, bottom: centerSide, start: centerSide, end: centerSide);
expect(centerBorderDirectional.dimensions, const EdgeInsetsDirectional.all(5));

const BorderSide outsideSide = BorderSide(width: 10, strokeAlign: BorderSide.strokeAlignOutside);
const BorderDirectional outsideBorderDirectional = BorderDirectional(top: outsideSide, bottom: outsideSide, start: outsideSide, end: outsideSide);
expect(outsideBorderDirectional.dimensions, EdgeInsetsDirectional.zero);

const Border nonUniformBorder = Border(
Expand All @@ -361,16 +314,12 @@ void main() {
end: BorderSide(width: 15, strokeAlign: BorderSide.strokeAlignOutside),
bottom: BorderSide(width: 20),
);
expect(nonUniformBorderDirectional.dimensions,
const EdgeInsetsDirectional.fromSTEB(5, 5, 0, 20));
expect(nonUniformBorderDirectional.dimensions, const EdgeInsetsDirectional.fromSTEB(5, 5, 0, 20));
});

testWidgetsWithLeakTracking('Non-Uniform Border variations',
(WidgetTester tester) async {
Widget buildWidget(
{required BoxBorder border,
BorderRadius? borderRadius,
BoxShape boxShape = BoxShape.rectangle}) {
testWidgetsWithLeakTracking('Non-Uniform Border variations', (WidgetTester tester) async {

Widget buildWidget({ required BoxBorder border, BorderRadius? borderRadius, BoxShape boxShape = BoxShape.rectangle}) {
return Directionality(
textDirection: TextDirection.ltr,
child: DecoratedBox(
Expand Down Expand Up @@ -402,8 +351,7 @@ void main() {
));
expect(tester.takeException(), isNull);

await tester.pumpWidget(buildWidget(
border: allowedBorderVariations, boxShape: BoxShape.circle));
await tester.pumpWidget(buildWidget(border: allowedBorderVariations, boxShape: BoxShape.circle));
expect(tester.takeException(), isNull);

await tester.pumpWidget(
Expand All @@ -418,8 +366,7 @@ void main() {
),
);
expect(tester.takeException(), isNull,
reason:
'Border with non-uniform styles should work with borderRadius.');
reason: 'Border with non-uniform styles should work with borderRadius.');

await tester.pumpWidget(
buildWidget(
Expand All @@ -433,8 +380,7 @@ void main() {
),
);
expect(tester.takeException(), isAssertionError,
reason:
'Border with non-uniform colors should fail with borderRadius.');
reason: 'Border with non-uniform colors should fail with borderRadius.');

await tester.pumpWidget(
buildWidget(
Expand All @@ -443,8 +389,7 @@ void main() {
),
);
expect(tester.takeException(), isNull,
reason:
'Border with a side.width == 0 should work without borderRadius (hairline border).');
reason: 'Border with a side.width == 0 should work without borderRadius (hairline border).');

await tester.pumpWidget(
buildWidget(
Expand All @@ -453,47 +398,37 @@ void main() {
),
);
expect(tester.takeException(), isAssertionError,
reason:
'Border with width == 0 and borderRadius should fail (hairline border).');
reason: 'Border with width == 0 and borderRadius should fail (hairline border).');

// Tests for BorderDirectional.
const BorderDirectional allowedBorderDirectionalVariations =
BorderDirectional(
const BorderDirectional allowedBorderDirectionalVariations = BorderDirectional(
start: BorderSide(width: 5),
top: BorderSide(width: 10, strokeAlign: BorderSide.strokeAlignCenter),
end: BorderSide(width: 15, strokeAlign: BorderSide.strokeAlignOutside),
bottom: BorderSide(width: 20),
);

await tester
.pumpWidget(buildWidget(border: allowedBorderDirectionalVariations));
await tester.pumpWidget(buildWidget(border: allowedBorderDirectionalVariations));
expect(tester.takeException(), isAssertionError);

await tester.pumpWidget(buildWidget(
border: allowedBorderDirectionalVariations,
borderRadius: BorderRadius.circular(25),
));
expect(tester.takeException(), isNull,
reason:
'BorderDirectional should not fail with uniform styles and colors.');
reason:'BorderDirectional should not fail with uniform styles and colors.');

await tester.pumpWidget(buildWidget(
border: allowedBorderDirectionalVariations, boxShape: BoxShape.circle));
await tester.pumpWidget(buildWidget(border: allowedBorderDirectionalVariations, boxShape: BoxShape.circle));
expect(tester.takeException(), isNull);
});

test('Compound borders with differing preferPaintInteriors', () {
expect(ShapeWithInterior().preferPaintInterior, isTrue);
expect(ShapeWithoutInterior().preferPaintInterior, isFalse);
expect((ShapeWithInterior() + ShapeWithInterior()).preferPaintInterior,
isTrue);
expect((ShapeWithInterior() + ShapeWithoutInterior()).preferPaintInterior,
isFalse);
expect((ShapeWithoutInterior() + ShapeWithInterior()).preferPaintInterior,
isFalse);
expect(
(ShapeWithoutInterior() + ShapeWithoutInterior()).preferPaintInterior,
isFalse);
expect((ShapeWithInterior() + ShapeWithInterior()).preferPaintInterior, isTrue);
expect((ShapeWithInterior() + ShapeWithoutInterior()).preferPaintInterior, isFalse);
expect((ShapeWithoutInterior() + ShapeWithInterior()).preferPaintInterior, isFalse);
expect((ShapeWithoutInterior() + ShapeWithoutInterior()).preferPaintInterior, isFalse);
});
}

Expand All @@ -510,21 +445,20 @@ class ShapeWithInterior extends ShapeBorder {
EdgeInsetsGeometry get dimensions => EdgeInsets.zero;

@override
Path getInnerPath(Rect rect, {TextDirection? textDirection}) {
Path getInnerPath(Rect rect, { TextDirection? textDirection }) {
return Path();
}

@override
Path getOuterPath(Rect rect, {TextDirection? textDirection}) {
Path getOuterPath(Rect rect, { TextDirection? textDirection }) {
return Path();
}

@override
void paintInterior(Canvas canvas, Rect rect, Paint paint,
{TextDirection? textDirection}) {}
void paintInterior(Canvas canvas, Rect rect, Paint paint, { TextDirection? textDirection }) { }

@override
void paint(Canvas canvas, Rect rect, {TextDirection? textDirection}) {}
void paint(Canvas canvas, Rect rect, { TextDirection? textDirection }) { }
}

class ShapeWithoutInterior extends ShapeBorder {
Expand All @@ -540,19 +474,18 @@ class ShapeWithoutInterior extends ShapeBorder {
EdgeInsetsGeometry get dimensions => EdgeInsets.zero;

@override
Path getInnerPath(Rect rect, {TextDirection? textDirection}) {
Path getInnerPath(Rect rect, { TextDirection? textDirection }) {
return Path();
}

@override
Path getOuterPath(Rect rect, {TextDirection? textDirection}) {
Path getOuterPath(Rect rect, { TextDirection? textDirection }) {
return Path();
}

@override
void paintInterior(Canvas canvas, Rect rect, Paint paint,
{TextDirection? textDirection}) {}
void paintInterior(Canvas canvas, Rect rect, Paint paint, { TextDirection? textDirection }) { }

@override
void paint(Canvas canvas, Rect rect, {TextDirection? textDirection}) {}
}
void paint(Canvas canvas, Rect rect, { TextDirection? textDirection }) { }
}