Visitar URL original
[a11y][android] In Android 16, sendWindowContentChangeEvent when check state changes by hannah-hyj · Pull Request #183606 · flutter/flutter · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Update AccessibilityBridge.java
  • Loading branch information
hannah-hyj committed Mar 12, 2026
commit 7450754deaac2c2d081ec16d86d45154dd14db63
Original file line number Diff line number Diff line change
Expand Up @@ -1914,7 +1914,7 @@ void updateSemantics(

// TODO(goderbauer): Send this event only once (!) for changed subtrees,
// see https://github.com/flutter/flutter/issues/14534
sendWindowContentChangeEvent(0);
sendWindowContentChangeEvent(0, AccessibilityEvent.CONTENT_CHANGE_TYPE_SUBTREE);

for (SemanticsNode object : updated) {
if (object.didScroll()) {
Expand Down Expand Up @@ -1982,7 +1982,10 @@ void updateSemantics(
sendAccessibilityEvent(event);
}
if (object.hasFlag(Flag.IS_LIVE_REGION) && object.didChangeLabel()) {
sendWindowContentChangeEvent(object.id);
sendWindowContentChangeEvent(object.id, AccessibilityEvent.CONTENT_CHANGE_TYPE_SUBTREE);
}
if (Build.VERSION.SDK_INT >= API_LEVELS.API_36 && object.didChangeCheckedState()) {
sendWindowContentChangeEvent(object.id, AccessibilityEvent.CONTENT_CHANGE_TYPE_CHECKED);
}
if (accessibilityFocusedSemanticsNode != null
&& accessibilityFocusedSemanticsNode.id == object.id
Expand Down Expand Up @@ -2150,16 +2153,14 @@ private void setAccessibilityPaneTitle(String title) {
* Creates a {@link AccessibilityEvent#TYPE_WINDOW_CONTENT_CHANGED} and sends the event to
* Android's accessibility system.
*
* <p>It sets the content change types to {@link AccessibilityEvent#CONTENT_CHANGE_TYPE_SUBTREE}
* when supported by the API level.
*
* <p>The given {@code virtualViewId} should be a {@link SemanticsNode} below which the content
* has changed.
*/
private void sendWindowContentChangeEvent(int virtualViewId) {

private void sendWindowContentChangeEvent(int virtualViewId, int changeType) {
AccessibilityEvent event =
obtainAccessibilityEvent(virtualViewId, AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED);
event.setContentChangeTypes(AccessibilityEvent.CONTENT_CHANGE_TYPE_SUBTREE);
event.setContentChangeTypes(changeType);
sendAccessibilityEvent(event);
}

Expand Down Expand Up @@ -2283,7 +2284,7 @@ public void reset() {
}
accessibilityFocusedSemanticsNode = null;
hoveredObject = null;
sendWindowContentChangeEvent(0);
sendWindowContentChangeEvent(0, AccessibilityEvent.CONTENT_CHANGE_TYPE_SUBTREE);
}

/**
Expand Down Expand Up @@ -2646,6 +2647,15 @@ private boolean didChangeLabel() {
return label == null || !label.equals(previousLabel);
}

private boolean didChangeCheckedState() {
if (!hadPreviousConfig) {
return false;
}
return (hasFlag(Flag.IS_CHECKED) != hadFlag(Flag.IS_CHECKED))
|| (hasFlag(Flag.IS_CHECK_STATE_MIXED) != hadFlag(Flag.IS_CHECK_STATE_MIXED))
|| (hasFlag(Flag.IS_TOGGLED) != hadFlag(Flag.IS_TOGGLED));
}

private void log(@NonNull String indent, boolean recursive) {
if (BuildConfig.DEBUG) {
Log.i(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2626,6 +2626,120 @@ public void itCanPerformCollapse() {
verify(mockChannel).dispatchSemanticsAction(0, AccessibilityBridge.Action.COLLAPSE);
}

@Config(sdk = API_LEVELS.API_36)
@TargetApi(API_LEVELS.API_36)
@Test
public void itSendsContentChangeCheckedOnAPI36ForCheckbox() {
View mockRootView = mock(View.class);
Context mockContext = mock(Context.class);
when(mockRootView.getContext()).thenReturn(mockContext);
when(mockContext.getPackageName()).thenReturn("test");
ViewParent mockParent = mock(ViewParent.class);
when(mockRootView.getParent()).thenReturn(mockParent);
AccessibilityManager mockManager = mock(AccessibilityManager.class);
when(mockManager.isEnabled()).thenReturn(true);

AccessibilityBridge accessibilityBridge = setUpBridge(mockRootView, mockManager, null);

TestSemanticsNode node = new TestSemanticsNode();
node.id = 0;
node.addFlag(AccessibilityBridge.Flag.HAS_CHECKED_STATE);
node.toUpdate().sendUpdateToBridge(accessibilityBridge);

// Change checked state
node.addFlag(AccessibilityBridge.Flag.IS_CHECKED);
node.toUpdate().sendUpdateToBridge(accessibilityBridge);

ArgumentCaptor<AccessibilityEvent> eventCaptor = ArgumentCaptor.forClass(AccessibilityEvent.class);
verify(mockParent, atLeastOnce()).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture());

boolean found = false;
for (AccessibilityEvent event : eventCaptor.getAllValues()) {
if (event.getEventType() == AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED
&& event.getContentChangeTypes() == AccessibilityEvent.CONTENT_CHANGE_TYPE_CHECKED) {
found = true;
break;
}
}
assertTrue("CONTENT_CHANGE_TYPE_CHECKED event not found for checkbox", found);
Comment thread
hannah-hyj marked this conversation as resolved.
Resolved
}

@Config(sdk = API_LEVELS.API_36)
@TargetApi(API_LEVELS.API_36)
@Test
public void itSendsContentChangeCheckedOnAPI36ForToggle() {
View mockRootView = mock(View.class);
Context mockContext = mock(Context.class);
when(mockRootView.getContext()).thenReturn(mockContext);
when(mockContext.getPackageName()).thenReturn("test");
ViewParent mockParent = mock(ViewParent.class);
when(mockRootView.getParent()).thenReturn(mockParent);
AccessibilityManager mockManager = mock(AccessibilityManager.class);
when(mockManager.isEnabled()).thenReturn(true);

AccessibilityBridge accessibilityBridge = setUpBridge(mockRootView, mockManager, null);

TestSemanticsNode node = new TestSemanticsNode();
node.id = 0;
node.addFlag(AccessibilityBridge.Flag.HAS_TOGGLED_STATE);
node.toUpdate().sendUpdateToBridge(accessibilityBridge);

// Change toggle state
node.addFlag(AccessibilityBridge.Flag.IS_TOGGLED);
node.toUpdate().sendUpdateToBridge(accessibilityBridge);

ArgumentCaptor<AccessibilityEvent> eventCaptor = ArgumentCaptor.forClass(AccessibilityEvent.class);
verify(mockParent, atLeastOnce()).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture());

boolean found = false;
for (AccessibilityEvent event : eventCaptor.getAllValues()) {
if (event.getEventType() == AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED
&& event.getContentChangeTypes() == AccessibilityEvent.CONTENT_CHANGE_TYPE_CHECKED) {
found = true;
break;
}
}
assertTrue("CONTENT_CHANGE_TYPE_CHECKED event not found for toggle", found);
Comment thread
hannah-hyj marked this conversation as resolved.
Resolved
}

@Config(sdk = API_LEVELS.API_36)
@TargetApi(API_LEVELS.API_36)
@Test
public void itSendsContentChangeCheckedOnAPI36ForMixedState() {
View mockRootView = mock(View.class);
Context mockContext = mock(Context.class);
when(mockRootView.getContext()).thenReturn(mockContext);
when(mockContext.getPackageName()).thenReturn("test");
ViewParent mockParent = mock(ViewParent.class);
when(mockRootView.getParent()).thenReturn(mockParent);
AccessibilityManager mockManager = mock(AccessibilityManager.class);
when(mockManager.isEnabled()).thenReturn(true);

AccessibilityBridge accessibilityBridge = setUpBridge(mockRootView, mockManager, null);

TestSemanticsNode node = new TestSemanticsNode();
node.id = 0;
node.addFlag(AccessibilityBridge.Flag.HAS_CHECKED_STATE);
node.toUpdate().sendUpdateToBridge(accessibilityBridge);

// Change to mixed state
node.addFlag(AccessibilityBridge.Flag.IS_CHECK_STATE_MIXED);
node.toUpdate().sendUpdateToBridge(accessibilityBridge);

ArgumentCaptor<AccessibilityEvent> eventCaptor = ArgumentCaptor.forClass(AccessibilityEvent.class);
verify(mockParent, atLeastOnce()).requestSendAccessibilityEvent(eq(mockRootView), eventCaptor.capture());

boolean found = false;
for (AccessibilityEvent event : eventCaptor.getAllValues()) {
if (event.getEventType() == AccessibilityEvent.TYPE_WINDOW_CONTENT_CHANGED
&& event.getContentChangeTypes() == AccessibilityEvent.CONTENT_CHANGE_TYPE_CHECKED) {
found = true;
break;
}
}
assertTrue("CONTENT_CHANGE_TYPE_CHECKED event not found for mixed state", found);
Comment thread
hannah-hyj marked this conversation as resolved.
Resolved
}

@Config(sdk = API_LEVELS.API_28)
@TargetApi(API_LEVELS.API_28)
@Test
Expand Down