Visitar URL original
Adds complex layout impeller startup benchmark by gaaclarke · Pull Request #183655 · flutter/flutter · GitHub
Skip to content

Adds complex layout impeller startup benchmark #183655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Mar 14, 2026
Merged

Adds complex layout impeller startup benchmark #183655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c8deee
adds complex startup for impeller
gaaclarke Mar 13, 2026
09b998c
added to ci
gaaclarke Mar 13, 2026
ae0ed57
bring up true
gaaclarke Mar 13, 2026
90c4efc
Update dev/devicelab/lib/tasks/perf_tests.dart
gaaclarke Mar 13, 2026
86fff1e
Revert "Update dev/devicelab/lib/tasks/perf_tests.dart"
gaaclarke Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3817,6 +3817,18 @@ targets:
tags: >
["framework", "hostonly", "shard", "mac"]

- name: Mac_benchmark complex_layout_macos_impeller__start_up
presubmit: false
recipe: devicelab/devicelab_drone
bringup: true
timeout: 60
properties:
dependencies: >-
[
{"dependency": "ruby", "version": "ruby_3.1-pod_1.13"}
]
task_name: complex_layout_macos_impeller__start_up

- name: Mac_benchmark complex_layout_macos__start_up
presubmit: false
recipe: devicelab/devicelab_drone
Expand Down
1 change: 1 addition & 0 deletions TESTOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@
/dev/devicelab/bin/tasks/build_ios_framework_module_test.dart @vashworth @flutter/tool
/dev/devicelab/bin/tasks/channels_integration_test_macos.dart @gaaclarke @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_macos__compile.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_macos_impeller__start_up.dart @gaaclarke @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_scroll_perf_macos__timeline_summary.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/complex_layout_win_desktop__compile.dart @yaakovschectman @flutter/desktop
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/complex_layout_macos__start_up.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ import 'package:flutter_devicelab/tasks/perf_tests.dart';

Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.macos;
await task(createComplexLayoutStartupTest());
await task(createComplexLayoutStartupTest(enableImpeller: false));
}
12 changes: 12 additions & 0 deletions dev/devicelab/bin/tasks/complex_layout_macos_impeller__start_up.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/perf_tests.dart';

Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.macos;
await task(createComplexLayoutStartupTest(enableImpeller: true));
}
11 changes: 9 additions & 2 deletions dev/devicelab/lib/tasks/perf_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,11 @@ TaskFunction createFlutterGalleryStartupTest({
).run;
}

TaskFunction createComplexLayoutStartupTest() {
return StartupTest('${flutterDirectory.path}/dev/benchmarks/complex_layout').run;
TaskFunction createComplexLayoutStartupTest({bool? enableImpeller}) {
return StartupTest(
'${flutterDirectory.path}/dev/benchmarks/complex_layout',
enableImpeller: enableImpeller,
).run;
}

TaskFunction createFlutterGalleryCompileTest() {
Expand Down Expand Up @@ -937,12 +940,14 @@ class StartupTest {
this.runEnvironment,
this.enableLazyShaderMode = false,
this.enableHcpp = false,
this.enableImpeller,
});

final String testDirectory;
final bool reportMetrics;
final bool enableLazyShaderMode;
final bool enableHcpp;
final bool? enableImpeller;
final String target;
final Map<String, String>? runEnvironment;

Expand Down Expand Up @@ -1062,6 +1067,8 @@ class StartupTest {
'-d',
device.deviceId,
if (applicationBinaryPath != null) '--use-application-binary=$applicationBinaryPath',
if (enableImpeller != null && enableImpeller!) '--enable-impeller',
if (enableImpeller != null && !enableImpeller!) '--no-enable-impeller',
],
environment: runEnvironment,
canFail: true,
Expand Down