Visitar URL original
Adds platform_view_test_macos_impeller by gaaclarke · Pull Request #183760 · flutter/flutter · GitHub
Skip to content

Adds platform_view_test_macos_impeller #183760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 2 commits into from
Mar 17, 2026
Merged

Adds platform_view_test_macos_impeller #183760

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1496ee6
Adds impeller platform_view_macos test
gaaclarke Mar 16, 2026
b28b815
added impeller test
gaaclarke Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4267,6 +4267,14 @@ targets:
properties:
task_name: platform_view_macos__start_up

- name: Mac_benchmark platform_view_macos_impeller__start_up
presubmit: false
recipe: devicelab/devicelab_drone
timeout: 60
bringup: true
properties:
task_name: platform_view_macos_impeller__start_up

- name: Mac platform_channel_sample_test_macos
recipe: devicelab/devicelab_drone
presubmit: false
Expand Down
1 change: 1 addition & 0 deletions TESTOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,7 @@
/dev/devicelab/bin/tasks/platform_channel_sample_test_macos.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/platform_channel_sample_test_windows.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/platform_view_macos__start_up.dart @cbracken @flutter/desktop
/dev/devicelab/bin/tasks/platform_view_macos_impeller__start_up.dart @loic-sharma @flutter/desktop
/dev/devicelab/bin/tasks/platform_view_win_desktop__start_up.dart @yaakovschectman @flutter/desktop
/dev/devicelab/bin/tasks/plugin_lint_mac.dart @stuartmorgan-g @flutter/plugin
/dev/devicelab/bin/tasks/plugin_test_android_standard.dart @stuartmorgan-g @flutter/plugin
Expand Down
2 changes: 1 addition & 1 deletion dev/devicelab/bin/tasks/platform_view_macos__start_up.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ import 'package:flutter_devicelab/tasks/perf_tests.dart';

Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.macos;
await task(createPlatformViewStartupTest());
await task(createPlatformViewStartupTest(enableImpeller: false));
}
12 changes: 12 additions & 0 deletions dev/devicelab/bin/tasks/platform_view_macos_impeller__start_up.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
// Copyright 2014 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

import 'package:flutter_devicelab/framework/devices.dart';
import 'package:flutter_devicelab/framework/framework.dart';
import 'package:flutter_devicelab/tasks/perf_tests.dart';

Future<void> main() async {
deviceOperatingSystem = DeviceOperatingSystem.macos;
await task(createPlatformViewStartupTest(enableImpeller: true));
}
8 changes: 6 additions & 2 deletions dev/devicelab/lib/tasks/perf_tests.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,8 +331,12 @@ TaskFunction createFlutterViewStartupTest() {
return StartupTest('${flutterDirectory.path}/examples/flutter_view', reportMetrics: false).run;
}

TaskFunction createPlatformViewStartupTest() {
return StartupTest('${flutterDirectory.path}/examples/platform_view', reportMetrics: false).run;
TaskFunction createPlatformViewStartupTest({bool? enableImpeller}) {

@gemini-code-assist gemini-code-assist Bot Mar 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The repository style guide requires all public members to have documentation. Please add a doc comment for the createPlatformViewStartupTest function to explain its purpose and parameters.

Suggested change
TaskFunction createPlatformViewStartupTest({bool? enableImpeller}) {
/// Creates a startup test for the platform view example.
///
/// If [enableImpeller] is true, the test will run with Impeller enabled.
/// If it is false, it will run with Impeller disabled. If it is null, the
/// default impeller setting for the platform will be used.
TaskFunction createPlatformViewStartupTest({bool? enableImpeller}) {
References
  1. All public members should have documentation. (link)

return StartupTest(
'${flutterDirectory.path}/examples/platform_view',
reportMetrics: false,
enableImpeller: enableImpeller,
).run;
}

TaskFunction createBasicMaterialCompileTest() {
Expand Down