Visitar URL original
Collect analytics on AI agent usage by jmagman · Pull Request #187630 · flutter/flutter · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,15 @@ Analytics getAnalytics({
}) {
final String version = flutterVersion.getVersionString(redactUnknownBranches: true);
final suppressEnvFlag = environment['FLUTTER_SUPPRESS_ANALYTICS']?.toLowerCase() == 'true';
final String? aiAgentName = AiAgent.detectAgentName(environment);
final hasAiAgent = aiAgentName != null;

if ( // Ignore local user branches.
version.startsWith('[user-branch]') ||
// Many CI systems don't do a full git checkout.
version.endsWith('/unknown') ||
// Ignore bots.
runningOnBot ||
// Ignore bots, unless run by an AI agent.
(runningOnBot && !hasAiAgent) ||
// Ignore when suppressed by FLUTTER_SUPPRESS_ANALYTICS.
suppressEnvFlag) {
return const NoOpAnalytics();
Expand All @@ -56,6 +58,7 @@ Analytics getAnalytics({
enableAsserts: enableAsserts,
clientIde: clientIde,
enabledFeatures: getEnabledFeatures(config),
agent: aiAgentName,
);
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -164,5 +164,54 @@ void main() {

expect(analytics.userProperty.clientIde, 'VSCode');
});

testWithoutContext(
'getAnalytics bypasses bot check when running on bots if run by an AI agent',
() {
// Normally returns NoOpAnalytics when running on bot
final Analytics analyticsNormalBot = getAnalytics(
runningOnBot: true,
flutterVersion: FakeFlutterVersion(),
environment: const <String, String>{},
analyticsOverride: analyticsOverride,
clientIde: clientIde,
config: config,
);
expect(analyticsNormalBot, isA<NoOpAnalytics>());

// Bypasses NoOpAnalytics check and returns analyticsOverride when AI agent is detected
final Analytics analyticsAgentBot = getAnalytics(
runningOnBot: true,
flutterVersion: FakeFlutterVersion(),
environment: const <String, String>{'CLAUDECODE': '1'},
analyticsOverride: analyticsOverride,
clientIde: clientIde,
config: config,
);
expect(analyticsAgentBot, isNot(isA<NoOpAnalytics>()));
expect(analyticsAgentBot, equals(analyticsOverride));
},
);

testWithoutContext('Agent is passed and found in events', () {
final FakeAnalytics fakeAnalytics = getInitializedFakeAnalyticsInstance(
fs: fs,
fakeFlutterVersion: FakeFlutterVersion(),
clientIde: clientIde,
agent: 'Claude Code',
);

final Analytics analytics = getAnalytics(
runningOnBot: false,
flutterVersion: FakeFlutterVersion(),
environment: const <String, String>{},
analyticsOverride: fakeAnalytics,
clientIde: clientIde,
config: config,
);
analytics as FakeAnalytics;

expect(analytics.userProperty.aiAgent, 'Claude Code');
});
});
}
2 changes: 2 additions & 0 deletions packages/flutter_tools/test/src/common.dart
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,7 @@ FakeAnalytics getInitializedFakeAnalyticsInstance({
required FakeFlutterVersion fakeFlutterVersion,
String? clientIde,
String? enabledFeatures,
String? agent,
}) {
final Directory homeDirectory = fs.directory('/');
final FakeAnalytics initialAnalytics = Analytics.fake(
Expand All @@ -355,6 +356,7 @@ FakeAnalytics getInitializedFakeAnalyticsInstance({
flutterVersion: fakeFlutterVersion.getVersionString(),
clientIde: clientIde,
enabledFeatures: enabledFeatures,
agent: agent,
);
}

Expand Down
Loading