Visitar URL original
Expose skipTraversal in FocusableActionDetector by ishaquehassan · Pull Request #191308 · flutter/flutter · GitHub
Skip to content

Expose skipTraversal in FocusableActionDetector - #191308

Merged
auto-submit[bot] merged 2 commits into
flutter:masterfrom
ishaquehassan:fix/187093-focusableactiondetector-skiptraversal
Sep 3, 2026
Merged

Expose skipTraversal in FocusableActionDetector#191308
auto-submit[bot] merged 2 commits into
flutter:masterfrom
ishaquehassan:fix/187093-focusableactiondetector-skiptraversal

Conversation

@ishaquehassan

@ishaquehassan ishaquehassan commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

FocusableActionDetector wraps a Focus widget internally and forwards focusNode, autofocus, descendantsAreFocusable, and descendantsAreTraversable, but not skipTraversal. That leaves no way to keep a FocusableActionDetector in the focus chain for key events while excluding it from focus traversal, even though the inner Focus already supports exactly that.

This adds a skipTraversal parameter to FocusableActionDetector and passes it straight through to the inner Focus. It is typed bool? to match Focus.skipTraversal, so the default of null keeps the current behavior and Focus still resolves it to false unless a focus node overrides it. The skipTraversal documentation on Focus is pulled into a {@template flutter.widgets.Focus.skipTraversal} block so FocusableActionDetector can reuse it with {@macro}, the same convention already used for descendantsAreFocusable and descendantsAreTraversable.

This revives #187356, which picked up an LGTM before it was auto closed after 21 days without a reply. That earlier PR also bundled some unrelated private named parameter changes that drew review comments, so this version is trimmed down to just the skipTraversal forwarding plus its test.

Fixes #187093

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Aug 18, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the skipTraversal property to FocusableActionDetector and forwards it to the inner Focus widget, with corresponding test coverage and documentation updates. The review feedback recommends adding skipTraversal to debugFillProperties in FocusableActionDetector to make it inspectable in the diagnostics tree.

Comment thread packages/flutter/lib/src/widgets/actions.dart
final bool descendantsAreTraversable;

/// {@macro flutter.widgets.Focus.skipTraversal}
final bool? skipTraversal;

@gemini-code-assist gemini-code-assist Bot Aug 18, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Consider adding skipTraversal to debugFillProperties in FocusableActionDetector so that it is inspectable in the diagnostics tree and DevTools.

Example:

properties.add(DiagnosticsProperty<bool>('skipTraversal', skipTraversal, defaultValue: null));

@ishaquehassan ishaquehassan Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at this one. FocusableActionDetector doesn't define debugFillProperties at all, so there's no existing override to add this to. The only two in actions.dart are on Actions and _OverridableActionMixin.

Adding one here just for skipTraversal would leave the other 13 properties on the widget out of diagnostics, which felt worse than leaving it alone, and it's a bit outside what this PR is doing. Happy to send a separate PR that fills it in properly for the whole widget if that's useful.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: focus Focus traversal, gaining or losing focus labels Aug 18, 2026
victorsanni
victorsanni previously approved these changes Aug 27, 2026
View reviewed changes
Renzo-Olivares
Renzo-Olivares reviewed Aug 27, 2026
View reviewed changes

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ishaquehassan, thank you for the contribution. I had one comment about the testing but other wise LGTM.

Comment thread packages/flutter/test/widgets/actions_test.dart
expect(buttonNode2.hasFocus, isFalse);
});

testWidgets('FocusableActionDetector forwards skipTraversal to Focus', (

@Renzo-Olivares Renzo-Olivares Aug 27, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding to this test, or creating a new test that verifies that that the traversal focus skip behavior works with FocusableActionDetector.

@ishaquehassan ishaquehassan Aug 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a behavior test for this. It focuses the node before the detector, calls nextFocus, and checks focus lands on the node after it instead of on the detector, plus that the detector can still be focused explicitly.

Sanity checked it by dropping the skipTraversal forwarding out of actions.dart, and the traversal assertion fails without it, so the test is actually covering the change.

@ishaquehassan
Expose skipTraversal in FocusableActionDetector
20a16d3 
FocusableActionDetector wraps a Focus internally and forwards focusNode,
autofocus, descendantsAreFocusable, and descendantsAreTraversable, but
not skipTraversal, so there was no way to keep it in the focus chain for
key events while excluding it from traversal.

Add a bool? skipTraversal parameter that passes straight through to the
inner Focus. The null default preserves current behavior. The Focus
skipTraversal doc is pulled into a shared {@template} block and reused
on FocusableActionDetector via {@macro}, matching the existing
descendantsAreFocusable and descendantsAreTraversable convention.

Adds a widget test covering the default and forwarded values.

Fixes flutter#187093
@ishaquehassan
Add a traversal behavior test for FocusableActionDetector.skipTraversal
c5563b7 
The existing test only checked that the value reaches the inner Focus, which
verifies the plumbing rather than the behavior anyone relies on. This adds a
test that actually traverses: with skipTraversal set, nextFocus moves straight
past the detector to the following node, and the detector can still be focused
explicitly, which is the distinction between skipTraversal and canRequestFocus.

Confirmed the test is not vacuous by removing the forwarding line in
actions.dart and watching it fail on the traversal assertion.
@ishaquehassan
ishaquehassan force-pushed the fix/187093-focusableactiondetector-skiptraversal branch from a01d211 to c5563b7 Compare August 28, 2026 14:28
Renzo-Olivares
Renzo-Olivares approved these changes Sep 1, 2026
View reviewed changes

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Renzo-Olivares Renzo-Olivares added the CICD Run CI/CD label Sep 1, 2026
victorsanni
victorsanni approved these changes Sep 2, 2026
View reviewed changes

@victorsanni victorsanni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@victorsanni victorsanni added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 2, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 2, 2026
Merged via the queue into flutter:master with commit c999d99 Sep 3, 2026
29 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 3, 2026
This was referenced Sep 3, 2026
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 4, 2026
@engine-flutter-autoroll
Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions) (#…
a929c2f 
…12760)

Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions)

Manual roll requested by bensonluk@google.com

flutter/flutter@70797e1...5a6cfa7

2026-09-04 bkonyi@google.com [tool] Migrate ScreenshotCommand to modular dependency injection (flutter/flutter#190767)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 8fce167bdded to 93ac1e630d1d (3 revisions) (flutter/flutter#192306)
2026-09-04 okorohelijah@google.com Add iOS Universal Link integration test (Simulator) (flutter/flutter#191443)
2026-09-04 269567208+reidbaker-agent@users.noreply.github.com [AGP 9.1.0 Migration #5] Delete getLegacyAndroidExtension and migrate NDK fallback to public DSL (flutter/flutter#192116)
2026-09-04 bkonyi@google.com Reland "[tool_tests] Remove bringup from Windows tool_tests_commands_2_2" (#191732) (flutter/flutter#191802)
2026-09-04 bkonyi@google.com [flutter_tools] Fix unhandled DebugAdapterException on early process termination (flutter/flutter#192294)
2026-09-04 engine-flutter-autoroll@skia.org Roll Packages from f9b3954 to 9af9c60 (4 revisions) (flutter/flutter#192292)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 2e3f7e07eee6 to 8fce167bdded (5 revisions) (flutter/flutter#192283)
2026-09-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GTZNkoIR_WegRPWgL... to FgDQeF6jb1dVRVh3K... (flutter/flutter#192276)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from b6b00df360e5 to 2e3f7e07eee6 (2 revisions) (flutter/flutter#192275)
2026-09-04 cetinibrahim.ci@gmail.com [iOS] TextField should support typing accented words with external keyboard (flutter/flutter#191062)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 1f68c0b16f17 to b6b00df360e5 (7 revisions) (flutter/flutter#192269)
2026-09-04 kevmoo@users.noreply.github.com [flutter_tools] add typed enum and defaulted option descriptors (flutter/flutter#191760)
2026-09-04 engine-flutter-autoroll@skia.org Roll Dart SDK from c2edc382a4f8 to 5501d02b583d (1 revision) (flutter/flutter#192263)
2026-09-04 robert.ancell@canonical.com [Linux] Use fences to synchronize frames between OpenGL contexts (flutter/flutter#192098)
2026-09-03 brunocorona.alcantar@gmail.com Defer semantics geometry updates for blocked branches (flutter/flutter#192146)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 8d3e197531c6 to 1f68c0b16f17 (8 revisions) (flutter/flutter#192244)
2026-09-03 57765714+Vi-debug@users.noreply.github.com Fix DeleteSurrounding splitting UTF-16 surrogate pairs (flutter/flutter#190514)
2026-09-03 32538273+ValentinVignal@users.noreply.github.com Remove no-shuffle from progress indicator test (flutter/flutter#186655)
2026-09-03 srawlins@google.com [material] Remove unused parameters from constructors of generic test class (flutter/flutter#191764)
2026-09-03 97480502+b-luk@users.noreply.github.com Handle linear and radial gradients in UberSDF (re-implement after fix) (flutter/flutter#192124)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from fcbfb64f42a1 to c2edc382a4f8 (2 revisions) (flutter/flutter#192240)
2026-09-03 34871572+gmackall@users.noreply.github.com Fix parsing of --enable-hcpp-and-surface-control switch and add --no-enable-hcpp tests (flutter/flutter#192202)
2026-09-03 97480502+b-luk@users.noreply.github.com Fix issue where shapes rendered with gradient+blur+rotation end up incorrectly cut off (flutter/flutter#192136)
2026-09-03 47866232+chunhtai@users.noreply.github.com Fix sibling nodes crash under MergeSemantics (flutter/flutter#191587)
2026-09-03 30870216+gaaclarke@users.noreply.github.com Makes backdrop groups operate on the union. (flutter/flutter#191838)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 008936396810 to 8d3e197531c6 (1 revision) (flutter/flutter#192236)
2026-09-03 parlough@gmail.com [docs] Remove superseded AI rules for Flutter (flutter/flutter#192185)
2026-09-03 15619084+vashworth@users.noreply.github.com Collect analytics about SwiftPM errors and warnings (flutter/flutter#191746)
2026-09-03 engine-flutter-autoroll@skia.org Roll Packages from 18fe786 to f9b3954 (7 revisions) (flutter/flutter#192235)
2026-09-03 robert.ancell@canonical.com [Linux] Remove frame sharing between OpenGL contexts (flutter/flutter#192150)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from cf79067a1e44 to fcbfb64f42a1 (1 revision) (flutter/flutter#192228)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 731fe9af4c0b to 008936396810 (3 revisions) (flutter/flutter#192225)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 700ab60bfe53 to cf79067a1e44 (2 revisions) (flutter/flutter#192219)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 823f82e18177 to 731fe9af4c0b (5 revisions) (flutter/flutter#192217)
2026-09-03 louisehsu@google.com Fixes OverlayPortal semantics bounds corruption (flutter/flutter#192139)
2026-09-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from idslm9FikVLy2K_A-... to GTZNkoIR_WegRPWgL... (flutter/flutter#192215)
2026-09-03 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from u_fSMsPU22VvUsvSo... to VObjlh3xw2P9sEbC_... (flutter/flutter#192212)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from ae22da2e8308 to 823f82e18177 (13 revisions) (flutter/flutter#192209)
2026-09-02 ishaquehassan@gmail.com Expose skipTraversal in FocusableActionDetector (flutter/flutter#191308)
2026-09-02 97480502+b-luk@users.noreply.github.com Add `IsProgram` mock method to `MockGLESImpl`, use it in `BufferBindingsGLESTest` (flutter/flutter#192196)
2026-09-02 uros.radulovic23@gmail.com Fix nested scroll view fling crash (flutter/flutter#191130)
2026-09-02 brunocorona.alcantar@gmail.com Fix TabBarView/PageView edge auto-scroll during mouse text selection (flutter/flutter#189544)
2026-09-02 30870216+gaaclarke@users.noreply.github.com Bypass gamma correction when alpha >= 1.0 (flutter/flutter#192193)
...
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll @victorsanni
Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions) (f…
84e4c44 
…lutter#12760)

Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions)

Manual roll requested by bensonluk@google.com

flutter/flutter@70797e1...5a6cfa7

2026-09-04 bkonyi@google.com [tool] Migrate ScreenshotCommand to modular dependency injection (flutter/flutter#190767)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 8fce167bdded to 93ac1e630d1d (3 revisions) (flutter/flutter#192306)
2026-09-04 okorohelijah@google.com Add iOS Universal Link integration test (Simulator) (flutter/flutter#191443)
2026-09-04 269567208+reidbaker-agent@users.noreply.github.com [AGP 9.1.0 Migration flutter#5] Delete getLegacyAndroidExtension and migrate NDK fallback to public DSL (flutter/flutter#192116)
2026-09-04 bkonyi@google.com Reland "[tool_tests] Remove bringup from Windows tool_tests_commands_2_2" (#191732) (flutter/flutter#191802)
2026-09-04 bkonyi@google.com [flutter_tools] Fix unhandled DebugAdapterException on early process termination (flutter/flutter#192294)
2026-09-04 engine-flutter-autoroll@skia.org Roll Packages from f9b3954 to 9af9c60 (4 revisions) (flutter/flutter#192292)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 2e3f7e07eee6 to 8fce167bdded (5 revisions) (flutter/flutter#192283)
2026-09-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GTZNkoIR_WegRPWgL... to FgDQeF6jb1dVRVh3K... (flutter/flutter#192276)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from b6b00df360e5 to 2e3f7e07eee6 (2 revisions) (flutter/flutter#192275)
2026-09-04 cetinibrahim.ci@gmail.com [iOS] TextField should support typing accented words with external keyboard (flutter/flutter#191062)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 1f68c0b16f17 to b6b00df360e5 (7 revisions) (flutter/flutter#192269)
2026-09-04 kevmoo@users.noreply.github.com [flutter_tools] add typed enum and defaulted option descriptors (flutter/flutter#191760)
2026-09-04 engine-flutter-autoroll@skia.org Roll Dart SDK from c2edc382a4f8 to 5501d02b583d (1 revision) (flutter/flutter#192263)
2026-09-04 robert.ancell@canonical.com [Linux] Use fences to synchronize frames between OpenGL contexts (flutter/flutter#192098)
2026-09-03 brunocorona.alcantar@gmail.com Defer semantics geometry updates for blocked branches (flutter/flutter#192146)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 8d3e197531c6 to 1f68c0b16f17 (8 revisions) (flutter/flutter#192244)
2026-09-03 57765714+Vi-debug@users.noreply.github.com Fix DeleteSurrounding splitting UTF-16 surrogate pairs (flutter/flutter#190514)
2026-09-03 32538273+ValentinVignal@users.noreply.github.com Remove no-shuffle from progress indicator test (flutter/flutter#186655)
2026-09-03 srawlins@google.com [material] Remove unused parameters from constructors of generic test class (flutter/flutter#191764)
2026-09-03 97480502+b-luk@users.noreply.github.com Handle linear and radial gradients in UberSDF (re-implement after fix) (flutter/flutter#192124)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from fcbfb64f42a1 to c2edc382a4f8 (2 revisions) (flutter/flutter#192240)
2026-09-03 34871572+gmackall@users.noreply.github.com Fix parsing of --enable-hcpp-and-surface-control switch and add --no-enable-hcpp tests (flutter/flutter#192202)
2026-09-03 97480502+b-luk@users.noreply.github.com Fix issue where shapes rendered with gradient+blur+rotation end up incorrectly cut off (flutter/flutter#192136)
2026-09-03 47866232+chunhtai@users.noreply.github.com Fix sibling nodes crash under MergeSemantics (flutter/flutter#191587)
2026-09-03 30870216+gaaclarke@users.noreply.github.com Makes backdrop groups operate on the union. (flutter/flutter#191838)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 008936396810 to 8d3e197531c6 (1 revision) (flutter/flutter#192236)
2026-09-03 parlough@gmail.com [docs] Remove superseded AI rules for Flutter (flutter/flutter#192185)
2026-09-03 15619084+vashworth@users.noreply.github.com Collect analytics about SwiftPM errors and warnings (flutter/flutter#191746)
2026-09-03 engine-flutter-autoroll@skia.org Roll Packages from 18fe786 to f9b3954 (7 revisions) (flutter/flutter#192235)
2026-09-03 robert.ancell@canonical.com [Linux] Remove frame sharing between OpenGL contexts (flutter/flutter#192150)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from cf79067a1e44 to fcbfb64f42a1 (1 revision) (flutter/flutter#192228)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 731fe9af4c0b to 008936396810 (3 revisions) (flutter/flutter#192225)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 700ab60bfe53 to cf79067a1e44 (2 revisions) (flutter/flutter#192219)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 823f82e18177 to 731fe9af4c0b (5 revisions) (flutter/flutter#192217)
2026-09-03 louisehsu@google.com Fixes OverlayPortal semantics bounds corruption (flutter/flutter#192139)
2026-09-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from idslm9FikVLy2K_A-... to GTZNkoIR_WegRPWgL... (flutter/flutter#192215)
2026-09-03 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from u_fSMsPU22VvUsvSo... to VObjlh3xw2P9sEbC_... (flutter/flutter#192212)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from ae22da2e8308 to 823f82e18177 (13 revisions) (flutter/flutter#192209)
2026-09-02 ishaquehassan@gmail.com Expose skipTraversal in FocusableActionDetector (flutter/flutter#191308)
2026-09-02 97480502+b-luk@users.noreply.github.com Add `IsProgram` mock method to `MockGLESImpl`, use it in `BufferBindingsGLESTest` (flutter/flutter#192196)
2026-09-02 uros.radulovic23@gmail.com Fix nested scroll view fling crash (flutter/flutter#191130)
2026-09-02 brunocorona.alcantar@gmail.com Fix TabBarView/PageView edge auto-scroll during mouse text selection (flutter/flutter#189544)
2026-09-02 30870216+gaaclarke@users.noreply.github.com Bypass gamma correction when alpha >= 1.0 (flutter/flutter#192193)
...
victorsanni pushed a commit to victorsanni/packages that referenced this pull request Sep 9, 2026
@engine-flutter-autoroll @victorsanni
Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions) (f…
899882f 
…lutter#12760)

Manual roll Flutter from 70797e15325e to 5a6cfa7f3d26 (52 revisions)

Manual roll requested by bensonluk@google.com

flutter/flutter@70797e1...5a6cfa7

2026-09-04 bkonyi@google.com [tool] Migrate ScreenshotCommand to modular dependency injection (flutter/flutter#190767)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 8fce167bdded to 93ac1e630d1d (3 revisions) (flutter/flutter#192306)
2026-09-04 okorohelijah@google.com Add iOS Universal Link integration test (Simulator) (flutter/flutter#191443)
2026-09-04 269567208+reidbaker-agent@users.noreply.github.com [AGP 9.1.0 Migration flutter#5] Delete getLegacyAndroidExtension and migrate NDK fallback to public DSL (flutter/flutter#192116)
2026-09-04 bkonyi@google.com Reland "[tool_tests] Remove bringup from Windows tool_tests_commands_2_2" (#191732) (flutter/flutter#191802)
2026-09-04 bkonyi@google.com [flutter_tools] Fix unhandled DebugAdapterException on early process termination (flutter/flutter#192294)
2026-09-04 engine-flutter-autoroll@skia.org Roll Packages from f9b3954 to 9af9c60 (4 revisions) (flutter/flutter#192292)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 2e3f7e07eee6 to 8fce167bdded (5 revisions) (flutter/flutter#192283)
2026-09-04 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from GTZNkoIR_WegRPWgL... to FgDQeF6jb1dVRVh3K... (flutter/flutter#192276)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from b6b00df360e5 to 2e3f7e07eee6 (2 revisions) (flutter/flutter#192275)
2026-09-04 cetinibrahim.ci@gmail.com [iOS] TextField should support typing accented words with external keyboard (flutter/flutter#191062)
2026-09-04 engine-flutter-autoroll@skia.org Roll Skia from 1f68c0b16f17 to b6b00df360e5 (7 revisions) (flutter/flutter#192269)
2026-09-04 kevmoo@users.noreply.github.com [flutter_tools] add typed enum and defaulted option descriptors (flutter/flutter#191760)
2026-09-04 engine-flutter-autoroll@skia.org Roll Dart SDK from c2edc382a4f8 to 5501d02b583d (1 revision) (flutter/flutter#192263)
2026-09-04 robert.ancell@canonical.com [Linux] Use fences to synchronize frames between OpenGL contexts (flutter/flutter#192098)
2026-09-03 brunocorona.alcantar@gmail.com Defer semantics geometry updates for blocked branches (flutter/flutter#192146)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 8d3e197531c6 to 1f68c0b16f17 (8 revisions) (flutter/flutter#192244)
2026-09-03 57765714+Vi-debug@users.noreply.github.com Fix DeleteSurrounding splitting UTF-16 surrogate pairs (flutter/flutter#190514)
2026-09-03 32538273+ValentinVignal@users.noreply.github.com Remove no-shuffle from progress indicator test (flutter/flutter#186655)
2026-09-03 srawlins@google.com [material] Remove unused parameters from constructors of generic test class (flutter/flutter#191764)
2026-09-03 97480502+b-luk@users.noreply.github.com Handle linear and radial gradients in UberSDF (re-implement after fix) (flutter/flutter#192124)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from fcbfb64f42a1 to c2edc382a4f8 (2 revisions) (flutter/flutter#192240)
2026-09-03 34871572+gmackall@users.noreply.github.com Fix parsing of --enable-hcpp-and-surface-control switch and add --no-enable-hcpp tests (flutter/flutter#192202)
2026-09-03 97480502+b-luk@users.noreply.github.com Fix issue where shapes rendered with gradient+blur+rotation end up incorrectly cut off (flutter/flutter#192136)
2026-09-03 47866232+chunhtai@users.noreply.github.com Fix sibling nodes crash under MergeSemantics (flutter/flutter#191587)
2026-09-03 30870216+gaaclarke@users.noreply.github.com Makes backdrop groups operate on the union. (flutter/flutter#191838)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 008936396810 to 8d3e197531c6 (1 revision) (flutter/flutter#192236)
2026-09-03 parlough@gmail.com [docs] Remove superseded AI rules for Flutter (flutter/flutter#192185)
2026-09-03 15619084+vashworth@users.noreply.github.com Collect analytics about SwiftPM errors and warnings (flutter/flutter#191746)
2026-09-03 engine-flutter-autoroll@skia.org Roll Packages from 18fe786 to f9b3954 (7 revisions) (flutter/flutter#192235)
2026-09-03 robert.ancell@canonical.com [Linux] Remove frame sharing between OpenGL contexts (flutter/flutter#192150)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from cf79067a1e44 to fcbfb64f42a1 (1 revision) (flutter/flutter#192228)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 731fe9af4c0b to 008936396810 (3 revisions) (flutter/flutter#192225)
2026-09-03 engine-flutter-autoroll@skia.org Roll Dart SDK from 700ab60bfe53 to cf79067a1e44 (2 revisions) (flutter/flutter#192219)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from 823f82e18177 to 731fe9af4c0b (5 revisions) (flutter/flutter#192217)
2026-09-03 louisehsu@google.com Fixes OverlayPortal semantics bounds corruption (flutter/flutter#192139)
2026-09-03 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from idslm9FikVLy2K_A-... to GTZNkoIR_WegRPWgL... (flutter/flutter#192215)
2026-09-03 engine-flutter-autoroll@skia.org Roll Fuchsia Test Scripts from u_fSMsPU22VvUsvSo... to VObjlh3xw2P9sEbC_... (flutter/flutter#192212)
2026-09-03 engine-flutter-autoroll@skia.org Roll Skia from ae22da2e8308 to 823f82e18177 (13 revisions) (flutter/flutter#192209)
2026-09-02 ishaquehassan@gmail.com Expose skipTraversal in FocusableActionDetector (flutter/flutter#191308)
2026-09-02 97480502+b-luk@users.noreply.github.com Add `IsProgram` mock method to `MockGLESImpl`, use it in `BufferBindingsGLESTest` (flutter/flutter#192196)
2026-09-02 uros.radulovic23@gmail.com Fix nested scroll view fling crash (flutter/flutter#191130)
2026-09-02 brunocorona.alcantar@gmail.com Fix TabBarView/PageView edge auto-scroll during mouse text selection (flutter/flutter#189544)
2026-09-02 30870216+gaaclarke@users.noreply.github.com Bypass gamma correction when alpha >= 1.0 (flutter/flutter#192193)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes
@victorsanni victorsanni victorsanni approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD f: focus Focus traversal, gaining or losing focus framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FocusableActionDetector should expose skipTraversal from Focus

3 participants

@ishaquehassan @Renzo-Olivares @victorsanni