Visitar URL original
Remove some `unawaited_futures` outdated ignores by AbdeMohlbi · Pull Request #192026 · flutter/flutter · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/flutter/lib/src/painting/_network_image_io.dart
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ class NetworkImage extends image_provider.ImageProvider<image_provider.NetworkIm
});
rethrow;
} finally {
// ignore: unawaited_futures
chunkEvents.close().catchError((Object error, StackTrace stack) {
FlutterError.reportError(
FlutterErrorDetails(
Expand Down
13 changes: 0 additions & 13 deletions packages/flutter/test/services/restoration_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ void main() {
addTearDown(manager.dispose);
final Future<RestorationBucket?> rootBucketFuture = manager.rootBucket;
RestorationBucket? rootBucket;
// ignore: unawaited_futures
rootBucketFuture.then((RestorationBucket? bucket) {
rootBucket = bucket;
});
Expand Down Expand Up @@ -65,7 +64,6 @@ void main() {

// Accessing the root bucket again completes synchronously with same bucket.
RestorationBucket? synchronousBucket;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
synchronousBucket = bucket;
});
Expand All @@ -88,7 +86,6 @@ void main() {
await _pushDataFromEngine(_createEncodedRestorationData1());

RestorationBucket? rootBucket;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) => rootBucket = bucket);
// Root bucket is available synchronously.
expect(rootBucket, isNotNull);
Expand All @@ -112,7 +109,6 @@ void main() {
addTearDown(manager.dispose);

RestorationBucket? rootBucket;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) => rootBucket = bucket);
expect(rootBucket, isNull);
expect(callsToEngine.single.method, 'get');
Expand All @@ -125,7 +121,6 @@ void main() {
await tester.pump();

RestorationBucket? rootBucket2;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) => rootBucket2 = bucket);
expect(rootBucket2, isNotNull);
expect(rootBucket2, same(rootBucket));
Expand All @@ -144,7 +139,6 @@ void main() {
final manager = RestorationManager();
addTearDown(manager.dispose);
RestorationBucket? rootBucket;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucket = bucket;
});
Expand Down Expand Up @@ -199,7 +193,6 @@ void main() {
addTearDown(manager.dispose);
RestorationBucket? rootBucket;
var rootBucketResolved = false;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucketResolved = true;
rootBucket = bucket;
Expand All @@ -216,7 +209,6 @@ void main() {
// Switch to non-null.
await _pushDataFromEngine(_createEncodedRestorationData1());
expect(listenerCount, 1);
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucket = bucket;
});
Expand All @@ -225,7 +217,6 @@ void main() {
// Switch to null again.
await _pushDataFromEngine(_packageRestorationData(enabled: false));
expect(listenerCount, 2);
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucket = bucket;
});
Expand All @@ -246,7 +237,6 @@ void main() {
addTearDown(manager.dispose);
final Future<RestorationBucket?> rootBucketFuture = manager.rootBucket;
RestorationBucket? rootBucket;
// ignore: unawaited_futures
rootBucketFuture.then((RestorationBucket? bucket) {
rootBucket = bucket;
});
Expand Down Expand Up @@ -285,7 +275,6 @@ void main() {
expect(manager.isReplacing, isFalse);

RestorationBucket? rootBucket;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucket = bucket;
});
Expand All @@ -301,7 +290,6 @@ void main() {

manager.receiveDataFromEngine(enabled: true, data: null);
RestorationBucket? rootBucket2;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucket2 = bucket;
});
Expand All @@ -319,7 +307,6 @@ void main() {

manager.receiveDataFromEngine(enabled: false, data: null);
RestorationBucket? rootBucket3;
// ignore: unawaited_futures
manager.rootBucket.then((RestorationBucket? bucket) {
rootBucket3 = bucket;
});
Expand Down
1 change: 0 additions & 1 deletion packages/flutter/test/widgets/widget_inspector_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5848,7 +5848,6 @@ class _TestWidgetInspectorService extends TestWidgetInspectorService {
final TestWidgetsFlutterBinding binding = TestWidgetsFlutterBinding.ensureInitialized();
// We need the runTest to setup the fake async in the test binding.
await binding.runTest(() async {
// ignore: unawaited_futures
binding.reassembleApplication();
await binding.pump();
}, () {});
Expand Down
Loading