Visitar URL original
Fix specify_nonobvious_local_variable_types lints in luci_resultdb_test.dart by bkonyi · Pull Request #192543 · flutter/flutter · GitHub
Skip to content

Fix specify_nonobvious_local_variable_types lints in luci_resultdb_test.dart #192543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 1 commit into from
Sep 10, 2026
Merged

Fix specify_nonobvious_local_variable_types lints in luci_resultdb_test.dart #192543

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions dev/bots/test/luci_resultdb_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ void main() {
parsed,
rootDirectory: '/b/s/w/ir/x/w/flutter',
);
final [LuciTestResult(testId: LuciStructuredTestId(:moduleName, :caseName))] = stripped;
final [LuciTestResult(testId: LuciStructuredTestId(:String moduleName, :String caseName))] =
stripped;
expect(moduleName, 'dev/foo/bar_test.dart');
expect(caseName, 'my test');

Expand Down Expand Up @@ -104,7 +105,7 @@ void main() {
workingDirectory: '/b/s/w/ir/x/w/flutter/packages/flutter',
rootDirectory: '/b/s/w/ir/x/w/flutter',
);
final [LuciTestResult(testId: LuciStructuredTestId(:moduleName))] = results;
final [LuciTestResult(testId: LuciStructuredTestId(:String moduleName))] = results;
expect(moduleName, 'packages/flutter/test/bar_test.dart');
});

Expand All @@ -122,7 +123,7 @@ void main() {
final List<LuciTestResult> results = convertToLuciTestResultsFormat(parsed);
// The raw test name is `Group: sub\path does x`; ':' becomes '\:' and the
// backslash becomes '\\'.
final [LuciTestResult(testId: LuciStructuredTestId(:caseName))] = results;
final [LuciTestResult(testId: LuciStructuredTestId(:String caseName))] = results;
expect(caseName, r'Group\: sub\\path does x');
});

Expand Down