Visitar URL original
[flutter_tools] Do not mistake server-initiated requests for responses to client requests in AnalysisServer by bkonyi · Pull Request #192546 · flutter/flutter · GitHub
Skip to content

[flutter_tools] Do not mistake server-initiated requests for responses to client requests in AnalysisServer - #192546

Merged
auto-submit[bot] merged 1 commit into
flutter:masterfrom
bkonyi:issue-192471
Sep 10, 2026
Merged

[flutter_tools] Do not mistake server-initiated requests for responses to client requests in AnalysisServer#192546
auto-submit[bot] merged 1 commit into
flutter:masterfrom
bkonyi:issue-192471

Conversation

@bkonyi

@bkonyi bkonyi commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

In JSON-RPC 2.0, server-to-client requests (such as window/workDoneProgress/create) include an ID allocated by the server along with a method. Previously, AnalysisServer._handleServerResponse checked _outstandingRequests for any message containing an ID before checking whether the message was a request or notification. If a server request happened to share an ID with an outstanding client request (e.g. dart/workspace/analysis/complete sent during waitForAnalysis), the server request was mistaken for an invalid response to the client request, causing an uncaught StateError that crashed the Flutter tool process and flaked tests in widget_preview_detection_test.dart.

This change separates the handling of incoming server messages (method != null) from responses to client requests (method == null), ensuring _outstandingRequests is only looked up for actual response messages.

Fixes #192471

@bkonyi
[flutter_tools] Do not mistake server-initiated requests for response…
9541a4c 
…s to client requests in AnalysisServer

In JSON-RPC 2.0, server-to-client requests (such as window/workDoneProgress/create)
include an ID allocated by the server along with a method. Previously,
AnalysisServer._handleServerResponse checked _outstandingRequests for any message
containing an ID before checking whether the message was a request or notification.
If a server request happened to share an ID with an outstanding client request
(e.g. dart/workspace/analysis/complete sent during waitForAnalysis),
the server request was mistaken for an invalid response to the client request,
causing an uncaught StateError that crashed the Flutter tool process and flaked
tests in widget_preview_detection_test.dart.

This change separates the handling of incoming server messages (method != null)
from responses to client requests (method == null), ensuring _outstandingRequests
is only looked up for actual response messages.

Fixes flutter#192471
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Sep 10, 2026
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Sep 10, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Sep 10, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the AnalysisServer to process outstanding client requests only when the incoming message does not contain a method field, ensuring that server-initiated requests sharing an ID with an outstanding client request are not incorrectly treated as responses. It also introduces mock helpers and a new unit test to verify this scenario. There are no review comments, and I have no feedback to provide.

@bkonyi
bkonyi requested a review from srawlins September 10, 2026 17:19
srawlins
srawlins approved these changes Sep 10, 2026
View reviewed changes

@srawlins srawlins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love that there are unit tests for this 😁

@bkonyi bkonyi added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Sep 10, 2026
Merged via the queue into flutter:master with commit 1d1b1cd Sep 10, 2026
27 of 28 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2026
This was referenced Sep 11, 2026
Closed
Closed
Closed
Closed
Closed
Merged
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Sep 12, 2026
@engine-flutter-autoroll
Roll Flutter from 63b9518f16bc to 2553f89be1ef (62 revisions) (#12855)
10495af 
Roll Flutter from 63b9518f16bc to 2553f89be1ef (62 revisions)

flutter/flutter@63b9518...2553f89

2026-09-12 chris@bracken.jp Roll clang to 07d67299a15ce03b053736e2d31a668ee0576987 (flutter/flutter#192607)
2026-09-12 engine-flutter-autoroll@skia.org Roll Dart SDK from b24b352c29db to 7863887acbfb (3 revisions) (flutter/flutter#192665)
2026-09-12 codefu@google.com fix(tree): et format --all (flutter/flutter#192669)
2026-09-12 matt.boetger@gmail.com Support activity-alias in Android launcher activity detection (flutter/flutter#187251)
2026-09-12 matt.boetger@gmail.com fix: regenerate gradle lockfiles for external_textures integration test (flutter/flutter#192657)
2026-09-12 engine-flutter-autoroll@skia.org Roll Skia from 51aa02b2c195 to e5e96533b732 (4 revisions) (flutter/flutter#192646)
2026-09-12 Rusino@users.noreply.github.com [WebParagraph] Fix text pixelation, glyph clipping, and snapping offsets to avoid subpixel raster caching (flutter/flutter#191736)
2026-09-12 codefu@google.com fix(tests): Add ruby dep to Mac windowing_test (flutter/flutter#192656)
2026-09-12 116356835+AbdeMohlbi@users.noreply.github.com Remove some `unawaited_futures` outdated ignores (flutter/flutter#192026)
2026-09-11 katelovett@google.com Bump Dart to 3.13, reformat, re-enable formatting check (flutter/flutter#192649)
2026-09-11 34871572+gmackall@users.noreply.github.com [android] Isolate API-34 high contrast listener in AccessibilityBridge behind Api34Impl (flutter/flutter#192502)
2026-09-11 katelovett@google.com Update style guide for Dart 3.13 (flutter/flutter#192639)
2026-09-11 codefu@google.com ci(bringups): remove bringup from these tests (flutter/flutter#192637)
2026-09-11 30870216+gaaclarke@users.noreply.github.com Unmark new_gallery_windows_impeller__transition_perf as bringup (flutter/flutter#192633)
2026-09-11 30870216+gaaclarke@users.noreply.github.com Unmark new_gallery_windows_skia__transition_perf as bringup (flutter/flutter#192635)
2026-09-11 engine-flutter-autoroll@skia.org Roll Skia from f446aec4ce9e to 51aa02b2c195 (2 revisions) (flutter/flutter#192631)
2026-09-11 codefu@google.com fix(ci): mac verify binaries still racing (flutter/flutter#192634)
2026-09-11 engine-flutter-autoroll@skia.org Roll Packages from 8a35b16 to 9caa77c (8 revisions) (flutter/flutter#192630)
2026-09-11 engine-flutter-autoroll@skia.org Roll Dart SDK from a76fee2722e0 to b24b352c29db (2 revisions) (flutter/flutter#192627)
2026-09-11 bkonyi@google.com [tool] Migrate PackagesCommand and Pub to modular dependency injection (flutter/flutter#192460)
2026-09-11 bkonyi@google.com [tool] Migrate Darwin framework commands to modular dependency injection (flutter/flutter#192252)
2026-09-11 bkonyi@google.com [tool] Migrate Upgrade, Downgrade, and UpdatePackages commands to modular dependency injection (flutter/flutter#190787)
2026-09-11 engine-flutter-autoroll@skia.org Roll Skia from b3fa80a0e168 to f446aec4ce9e (55 revisions) (flutter/flutter#192620)
2026-09-11 engine-flutter-autoroll@skia.org Roll Dart SDK from d20d59cfa664 to a76fee2722e0 (2 revisions) (flutter/flutter#192616)
2026-09-11 okorohelijah@google.com remove deeplink integration tests from bringup (flutter/flutter#192459)
2026-09-11 154381524+flutteractionsbot@users.noreply.github.com Revert: [devicelab] Clean up Chrome profile directories and trap abort signals in web benchmarks (flutter/flutter#192615)
2026-09-11 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from C0j8F-_Iy-OQZ6YyI... to m69nfK-wnHaMTe8P9... (flutter/flutter#192608)
2026-09-11 kevmoo@users.noreply.github.com Fix Wasm build cache mismatch in ResidentWebRunner and browser 404 fallbacks (flutter/flutter#190786)
2026-09-11 engine-flutter-autoroll@skia.org Roll Dart SDK from 3ce3116bc9ec to d20d59cfa664 (1 revision) (flutter/flutter#192588)
2026-09-11 robert.ancell@canonical.com [Linux] Keep the frame at the top of a resizing subsurface (flutter/flutter#192408)
2026-09-10 1961493+harryterkelsen@users.noreply.github.com [devicelab] Clean up Chrome profile directories and trap abort signals in web benchmarks (flutter/flutter#192584)
2026-09-10 1961493+harryterkelsen@users.noreply.github.com [web] Keep ImageSource alive until Picture disposal (flutter/flutter#192516)
2026-09-10 jhy03261997@gmail.com Remove the accessibility evaluations feature flag (flutter/flutter#192266)
2026-09-10 97480502+b-luk@users.noreply.github.com Promote Windows gradient benchmark tests to non-bringup (flutter/flutter#192581)
2026-09-10 116356835+AbdeMohlbi@users.noreply.github.com Remove commented out export in `text_input.dart` since the dart compiler has the correct behavior now (flutter/flutter#191539)
2026-09-10 bkonyi@google.com [flutter_tools] Do not mistake server-initiated requests for responses to client requests in AnalysisServer (flutter/flutter#192546)
2026-09-10 engine-flutter-autoroll@skia.org Roll Packages from 36e088a to 8a35b16 (12 revisions) (flutter/flutter#192550)
2026-09-10 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#192517)
2026-09-10 kevmoo@users.noreply.github.com feat(web): support --web-content-hash for entrypoint files (flutter/flutter#190153)
2026-09-10 zhongliu88889@gmail.com [web] Stop iOS auto-zoom by sizing semantic inputs at 16px (flutter/flutter#192328)
2026-09-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 0d55b7a6a9ee to 3ce3116bc9ec (2 revisions) (flutter/flutter#192534)
2026-09-10 116356835+AbdeMohlbi@users.noreply.github.com Update more enum instances comparison to use equality == since dart has the correct behavior now (flutter/flutter#191788)
2026-09-10 bkonyi@google.com Fix specify_nonobvious_local_variable_types lints in luci_resultdb_test.dart (flutter/flutter#192543)
2026-09-10 engine-flutter-autoroll@skia.org Roll ICU from 8cc91d9b6ab9 to 6ebb40c59477 (1 revision) (flutter/flutter#192527)
2026-09-10 robert.ancell@canonical.com [Linux] Make the framebuffer depth/stencil buffer optional (flutter/flutter#192156)
2026-09-10 robert.ancell@canonical.com [Linux] Cancel input when events stop being delivered (flutter/flutter#192277)
...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srawlins srawlins srawlins approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CICD Run CI/CD tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mac tool_integration_tests_10 is 2.04% flaky

2 participants

@bkonyi @srawlins