Visitar URL original
add shorthands for scroll physics subclasses in framework by navaronbracke · Pull Request #193082 · flutter/flutter · GitHub
Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix test assert
  • Loading branch information
navaronbracke committed Oct 9, 2026
commit dfaff2a788e2977cab8e2e8026fa60f261b2b2e6
45 changes: 34 additions & 11 deletions packages/flutter/test/widgets/scroll_physics_test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -497,17 +497,25 @@ FlutterError
ScrollableState scrollable = tester.state<ScrollableState>(find.byType(Scrollable));
final ScrollPosition firstPosition = scrollable.position;
expect(
(firstPosition.physics as BouncingScrollPhysics).decelerationRate,
ScrollDecelerationRate.normal,
firstPosition.physics,
isA<BouncingScrollPhysics>().having(
(BouncingScrollPhysics bouncingPhysics) => bouncingPhysics.decelerationRate,
'decelerationRate',
ScrollDecelerationRate.normal,
),
);

// Identical configuration should not recreate ScrollPosition.
await tester.pumpWidget(buildScrollable());
scrollable = tester.state<ScrollableState>(find.byType(Scrollable));
expect(scrollable.position, same(firstPosition));
expect(
(scrollable.position.physics as BouncingScrollPhysics).decelerationRate,
ScrollDecelerationRate.normal,
scrollable.position.physics,
isA<BouncingScrollPhysics>().having(
(BouncingScrollPhysics bouncingPhysics) => bouncingPhysics.decelerationRate,
'decelerationRate',
ScrollDecelerationRate.normal,
),
);

// Different decelerationRate should recreate ScrollPosition.
Expand All @@ -518,8 +526,12 @@ FlutterError
final ScrollPosition secondPosition = scrollable.position;
expect(secondPosition, isNot(same(firstPosition)));
expect(
(secondPosition.physics as BouncingScrollPhysics).decelerationRate,
ScrollDecelerationRate.fast,
secondPosition.physics,
isA<BouncingScrollPhysics>().having(
(BouncingScrollPhysics bouncingPhysics) => bouncingPhysics.decelerationRate,
'decelerationRate',
ScrollDecelerationRate.fast,
),
);
});

Expand Down Expand Up @@ -593,17 +605,29 @@ FlutterError
test('ScrollPhysics supports shorthands for BouncingScrollPhysics', () {
const ScrollPhysics physics = .bouncing();

expect(physics, isA<BouncingScrollPhysics>());
expect(physics.parent, isNull);
expect((physics as BouncingScrollPhysics).decelerationRate, ScrollDecelerationRate.normal);
expect(
physics,
isA<BouncingScrollPhysics>().having(
(BouncingScrollPhysics bouncingPhysics) => bouncingPhysics.decelerationRate,
'decelerationRate',
ScrollDecelerationRate.normal,
),
);

const ScrollPhysics physics2 = .bouncing(
parent: ClampingScrollPhysics(),
decelerationRate: ScrollDecelerationRate.fast,
);
expect(physics2, isA<BouncingScrollPhysics>());
expect(
physics2,
isA<BouncingScrollPhysics>().having(
(BouncingScrollPhysics bouncingPhysics) => bouncingPhysics.decelerationRate,
'decelerationRate',
ScrollDecelerationRate.fast,
),
);
expect(physics2.parent, isA<ClampingScrollPhysics>());
expect((physics2 as BouncingScrollPhysics).decelerationRate, ScrollDecelerationRate.fast);
});

test('ScrollPhysics supports shorthands for ClampingScrollPhysics', () {
Expand Down Expand Up @@ -639,7 +663,6 @@ FlutterError
physics = const .rangeMaintaining(parent: ClampingScrollPhysics());

expect(physics, isA<RangeMaintainingScrollPhysics>());

expect(physics.parent, isA<ClampingScrollPhysics>());
});
}
Expand Down
Loading