Visitar URL original
Remove more instances of deprecated `withOpacity` by AbdeMohlbi · Pull Request #193559 · flutter/flutter · GitHub
Skip to content

Remove more instances of deprecated withOpacity - #193559

Merged
auto-submit[bot] merged 6 commits into
flutter:masterfrom
AbdeMohlbi:opacity_removal_2
Oct 11, 2026
Merged

auto-submit[bot] merged 6 commits into
flutter:masterfrom
AbdeMohlbi:opacity_removal_2

Conversation

@AbdeMohlbi

@AbdeMohlbi AbdeMohlbi commented Sep 30, 2026 •

Copy link
Copy Markdown
Member

Similar PRs:

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If this change needs to override an active code freeze, provide a comment explaining why. The code freeze workflow can be overridden by code reviewers. See pinned issues for any active code freezes with guidance.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

@github-actions github-actions Bot added framework flutter/packages/flutter repository. See also f: labels. f: routes Navigator, Router, and related APIs. labels Sep 30, 2026
@AbdeMohlbi AbdeMohlbi added the CICD Run CI/CD label Sep 30, 2026
@AbdeMohlbi AbdeMohlbi changed the title Remove more of deprecated withOpacity Remove more instances of deprecated withOpacity Oct 1, 2026
@AbdeMohlbi
AbdeMohlbi marked this pull request as ready for review October 1, 2026 08:21

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request migrates usages of withOpacity to withValues(alpha: ...) across painting and widget files, as well as their corresponding tests. Feedback on the changes identifies an inconsistency in gradient_test.dart where withValues(alpha: 0.5) is applied to colors that already have an alpha value of 0x80 in their hex representation, rather than using the original base colors.

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AbdeMohlbi AbdeMohlbi added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2026
@auto-submit
auto-submit Bot added this pull request to the merge queue Oct 11, 2026
Merged via the queue into flutter:master with commit badb64c Oct 11, 2026
23 checks passed
@flutter-dashboard flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Oct 11, 2026
auto-submit Bot pushed a commit to flutter/packages that referenced this pull request Oct 14, 2026
…#13220)

Manual roll Flutter from d03768eef055 to 4249ccbc18a3 (158 revisions)

Manual roll requested by bmparr@google.com

flutter/flutter@d03768e...4249ccb

2026-10-12 269567208+reidbaker-agent@users.noreply.github.com [AGP 9.1.0 Migration #8] Unify add-to-app module wiring on the variant API (flutter/flutter#193717)
2026-10-12 154381524+flutteractionsbot@users.noreply.github.com [master] Update Flutter DEPS to Dart 5933cb486b4aef2f8cf6b9f89a5651c0d5b0955e (flutter/flutter#193982)
2026-10-12 34871572+gmackall@users.noreply.github.com [Android] Fix use-after-free of SurfaceControl.Transaction in HCPP (flutter/flutter#192969)
2026-10-12 97480502+b-luk@users.noreply.github.com [windows] Add OpenGL compositor tests against ANGLE at D3D11 feature level 10_0 (flutter/flutter#194114)
2026-10-12 evanwall@buffalo.edu Fix HDR image packing for ios (flutter/flutter#192526)
2026-10-12 katelovett@google.com Bump customer tests to pick up material_ui and cupertino_ui (flutter/flutter#194236)
2026-10-12 32538273+ValentinVignal@users.noreply.github.com Remove no-shuffle from text_field_test.dart (flutter/flutter#193550)
2026-10-12 zhongliu88889@gmail.com [web] Clip semantics DOM text labels to stop stealing taps (flutter/flutter#194011)
2026-10-12 engine-flutter-autoroll@skia.org Roll Skia from 9b6ceba4728d to 17f6986c226c (6 revisions) (flutter/flutter#194232)
2026-10-12 kevmoo@users.noreply.github.com [web] Skip non-focusable containers in Focusable.focusAsRouteDefault (flutter/flutter#194138)
2026-10-12 Rusino@users.noreply.github.com [web_paragraph] Honor kTextHeightNone in TextStyle and ParagraphStyle (flutter/flutter#193733)
2026-10-12 engine-flutter-autoroll@skia.org Roll Skia from c88b49d1d6c7 to 9b6ceba4728d (4 revisions) (flutter/flutter#194226)
2026-10-12 15619084+vashworth@users.noreply.github.com Migrate remaining test to macOS 26 (flutter/flutter#193825)
2026-10-12 engine-flutter-autoroll@skia.org Roll Dart SDK from 047ca322aa9c to 221363557163 (1 revision) (flutter/flutter#194219)
2026-10-12 dacoharkes@google.com [flutter_tools] Include dev_dependencies hooks for release integration tests (flutter/flutter#193436)
2026-10-12 engine-flutter-autoroll@skia.org Roll Skia from d8afad1b1829 to c88b49d1d6c7 (1 revision) (flutter/flutter#194198)
2026-10-12 engine-flutter-autoroll@skia.org Roll Skia from b23ddbff1265 to d8afad1b1829 (4 revisions) (flutter/flutter#194195)
2026-10-11 engine-flutter-autoroll@skia.org Roll Skia from a168863e44ec to b23ddbff1265 (1 revision) (flutter/flutter#194185)
2026-10-11 engine-flutter-autoroll@skia.org Roll Skia from 0c1d93abfa04 to a168863e44ec (1 revision) (flutter/flutter#194181)
2026-10-11 robert@odrowaz.dev iOS: Re-enable rendering on willEnterForeground (flutter/flutter#191350)
2026-10-11 engine-flutter-autoroll@skia.org Roll Skia from 93c9d3ffda25 to 0c1d93abfa04 (1 revision) (flutter/flutter#194179)
2026-10-11 116356835+AbdeMohlbi@users.noreply.github.com Remove more instances of deprecated `withOpacity` (flutter/flutter#193559)
2026-10-11 116356835+AbdeMohlbi@users.noreply.github.com Fix another `parameter_assignments` warning (flutter/flutter#193669)
2026-10-11 engine-flutter-autoroll@skia.org Roll Skia from 3136abef8f58 to 93c9d3ffda25 (1 revision) (flutter/flutter#194169)
2026-10-11 leehack@gmail.com [Impeller] Guard the sampler library caches with a mutex (flutter/flutter#193738)
2026-10-11 engine-flutter-autoroll@skia.org Roll Dart SDK from e9c89888bcc1 to 047ca322aa9c (1 revision) (flutter/flutter#194157)
2026-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 787baa8aae78 to e9c89888bcc1 (2 revisions) (flutter/flutter#194141)
2026-10-10 33060521+aayushkedawat@users.noreply.github.com Fix OverlayPortal layout in shrink-wrapped overlays (flutter/flutter#193079)
2026-10-10 engine-flutter-autoroll@skia.org Roll Skia from 353076e27b1c to 3136abef8f58 (1 revision) (flutter/flutter#194130)
2026-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 88a07589b1ff to 787baa8aae78 (1 revision) (flutter/flutter#194124)
2026-10-10 victorsanniay@gmail.com Route windowing view lookups through WidgetsBinding (flutter/flutter#192666)
2026-10-10 engine-flutter-autoroll@skia.org Roll Dart SDK from 2a06cab34715 to 88a07589b1ff (1 revision) (flutter/flutter#194117)
2026-10-10 engine-flutter-autoroll@skia.org Roll Skia from f9043b7aa798 to 353076e27b1c (2 revisions) (flutter/flutter#194115)
2026-10-10 30870216+gaaclarke@users.noreply.github.com Refactored PipelineLibraryGLES (flutter/flutter#193985)
2026-10-09 brackenavaron@gmail.com add shorthands for scroll physics subclasses in framework (flutter/flutter#193082)
2026-10-09 engine-flutter-autoroll@skia.org Roll Dart SDK from ba889e3cee8a to 2a06cab34715 (1 revision) (flutter/flutter#194105)
2026-10-09 engine-flutter-autoroll@skia.org Roll Skia from 5ea03d8a53a6 to f9043b7aa798 (2 revisions) (flutter/flutter#194099)
2026-10-09 mdebbar@google.com Add docs for using bb and led with LUCI (flutter/flutter#193859)
2026-10-09 engine-flutter-autoroll@skia.org Roll Skia from e329bb617820 to 5ea03d8a53a6 (5 revisions) (flutter/flutter#194087)
2026-10-09 engine-flutter-autoroll@skia.org Roll Packages from 54706bd to d8d9e97 (5 revisions) (flutter/flutter#194080)
2026-10-09 joel.winarske@gmail.com Move the Vulkan wrapped-texture helper out of the GPU surface (flutter/flutter#193001)
2026-10-09 engine-flutter-autoroll@skia.org Roll Skia from 3e54bcf4c963 to e329bb617820 (1 revision) (flutter/flutter#194078)
2026-10-09 engine-flutter-autoroll@skia.org Roll Dart SDK from 23f0308f9af8 to ba889e3cee8a (2 revisions) (flutter/flutter#194077)
2026-10-09 zarah@google.com Bump dartdoc to 9.0.11 (flutter/flutter#194076)
...
suryaKommana2662 pushed a commit to suryaKommana2662/flutter that referenced this pull request Oct 29, 2026
Similar PRs:  
- flutter#177374  
- flutter#177490  
- flutter#177540  
- flutter#177541  
- flutter#192583

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant in-code documentation (doc comments with
`///`).
- [ ] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CICD Run CI/CD f: routes Navigator, Router, and related APIs. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants