Visitar URL original
Revert: [flutter_tools] Apply web_dev_config.yaml proxy in Wasm/release modes by flutteractionsbot · Pull Request #193996 · flutter/flutter · GitHub
Skip to content

Revert: [flutter_tools] Apply web_dev_config.yaml proxy in Wasm/release modes - #193996

Closed
flutteractionsbot wants to merge 1 commit into
flutter:masterfrom
flutteractionsbot:revert-193981-1791452712
Closed

Revert: [flutter_tools] Apply web_dev_config.yaml proxy in Wasm/release modes#193996
flutteractionsbot wants to merge 1 commit into
flutter:masterfrom
flutteractionsbot:revert-193981-1791452712

Conversation

@flutteractionsbot

@flutteractionsbot flutteractionsbot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Reverts: [flutter_tools] Apply web_dev_config.yaml proxy in Wasm/release modes

Initiated by: @flar

Reason for reverting: broke the tree

Original PR Author: @kevmoo

Reviewed By: @harryterkelsen

The original PR description is provided below:

When flutter run serves web builds using ReleaseAssetServer (--wasm, --profile, or --release), WebAssetServer.start previously constructed the Shelf pipeline with only waitMiddleware and omitted proxyMiddleware. As a result, requests matching web_dev_config.yaml proxy rules bypassed the proxy and fell back to index.html (or returned 404 for non-GET methods).

This change:

  • Adds proxyMiddleware(proxy, logger) to the ReleaseAssetServer Shelf pipeline in WebAssetServer.start.
  • Passes the injected logger parameter to proxyMiddleware in the DWDS pipeline instead of globals.logger.
  • Adds WebAssetServer unit tests verifying proxied GET and POST requests alongside unmatched SPA route fallback for both debug (isWasm: true) and release (isWasm: false).

Fixes #187482

Pre-launch Checklist

@flutteractionsbot flutteractionsbot mentioned this pull request Oct 8, 2026
Merged
11 tasks done
@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 8, 2026
@github-actions github-actions Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 8, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 8, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the proxy middleware from the release handler pipeline in WebAssetServer and updates the remaining proxy middleware reference to use globals.logger. It also removes the unused devfs_proxy.dart import and deletes the proxy-related tests in web_asset_server_test.dart. No review comments were provided, and there is no additional feedback to provide.

@flar flar added autosubmit Merge PR when tree becomes green via auto submit App emergency Jump the queue; land PR in front of all others; only use for emergencies labels Oct 8, 2026
@flutter-dashboard

flutter-dashboard Bot commented Oct 8, 2026

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@flar

flar commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

This revert is failing in exactly the same way that the original PR was failing, so this is not the right fix.

@flar flar closed this Oct 8, 2026
@flutteractionsbot
flutteractionsbot deleted the revert-193981-1791452712 branch October 8, 2026 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD emergency Jump the queue; land PR in front of all others; only use for emergencies tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

web_dev_config.yaml proxy that works for js web does not work with --wasm flag

2 participants

@flutteractionsbot @flar