Visitar URL original
Bump multicast_dns version by blasten · Pull Request #32126 · flutter/flutter · GitHub
Skip to content

Bump multicast_dns version - #32126

Merged
blasten merged 2 commits into
flutter:masterfrom
blasten:bump-multicast-dns
May 6, 2019
Merged

blasten merged 2 commits into
flutter:masterfrom
blasten:bump-multicast-dns

Conversation

@blasten

@blasten blasten commented May 6, 2019

Copy link
Copy Markdown

Description

This new version includes the fix from flutter/packages#20

Related Issues

Flutter attach crashes with FormatException: #31854

Tests

n/a

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require Flutter developers to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (Please read Handling breaking changes). Replace this with a link to the e-mail where you asked for input on this proposed change.
  • No, this is not a breaking change.

@goderbauer goderbauer added the tool Affects the "flutter" command-line tool. See also t: labels. label May 6, 2019
@goderbauer

Copy link
Copy Markdown
Member

If you haven't already, you'll need to run flutter update-packages --force-upgrade and check in the pubspec files that changed due to that.

@blasten
blasten marked this pull request as ready for review May 6, 2019 16:06
@blasten
blasten requested a review from dnfield May 6, 2019 16:06

@dnfield dnfield left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@blasten
blasten merged commit cc7ec6d into flutter:master May 6, 2019
@blasten
blasten deleted the bump-multicast-dns branch May 6, 2019 19:29
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants