Repository navigation
[webview_flutter_wkwebview] Retain registrar for WebKit callbacks - #13140
Draft
tomvoaxpara wants to merge 1 commit into
Draft
tomvoaxpara wants to merge 1 commit into
tomvoaxpara wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handwritten WebKit callback implementations currently keep an
unownedreference to their
ProxyAPIRegistrar. WebKit can retain those callback objectsafter the plugin owner has been torn down, so a late callback can dereference a
deallocated registrar and abort the process.
This change keeps the registrar alive for the lifetime of each callback object.
Plugin teardown still clears the instance manager before releasing its registrar,
which breaks registrar/callback cycles owned by the plugin.
Part of flutter/flutter#192975. This complements #13130, which handles the
separate generated-codec lifetime during in-flight encoding.
Tests
webview_flutter_wkwebviewPre-Review Checklist
[shared_preferences]///).No public API or documentation changes are needed for this ownership fix.
If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2