Visitar URL original
[webview_flutter_wkwebview] Retain registrar for WebKit callbacks by tomvoaxpara · Pull Request #13140 · flutter/packages · GitHub
Skip to content

[webview_flutter_wkwebview] Retain registrar for WebKit callbacks - #13140

Draft
tomvoaxpara wants to merge 1 commit into
flutter:mainfrom
tomvoaxpara:fix-192975-webview-callback-lifetime
Draft

tomvoaxpara wants to merge 1 commit into
flutter:mainfrom
tomvoaxpara:fix-192975-webview-callback-lifetime

Conversation

@tomvoaxpara

Copy link
Copy Markdown

The handwritten WebKit callback implementations currently keep an unowned
reference to their ProxyAPIRegistrar. WebKit can retain those callback objects
after the plugin owner has been torn down, so a late callback can dereference a
deallocated registrar and abort the process.

This change keeps the registrar alive for the lifetime of each callback object.
Plugin teardown still clears the instance manager before releasing its registrar,
which breaks registrar/callback cycles owned by the plugin.

Part of flutter/flutter#192975. This complements #13130, which handles the
separate generated-codec lifetime during in-flight encoding.

Tests

  • Swift format and strict lint for webview_flutter_wkwebview
  • iOS example build
  • iOS native unit tests: 147 passed
  • Dart tests: 158 passed
  • Dart and iOS analysis

Pre-Review Checklist

No public API or documentation changes are needed for this ownership fix.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@google-cla

google-cla Bot commented Oct 6, 2026

Copy link
Copy Markdown

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant