Visitar URL original
[Pigeon] added iOS e2e tests and fixed dart style warnings by gaaclarke · Pull Request #143 · flutter/packages · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
formatter again
  • Loading branch information
gaaclarke committed Apr 22, 2020
commit 0ad54d2d6fa3731fe558ac9104af378a0d3c6ac3
2 changes: 1 addition & 1 deletion packages/pigeon/e2e_tests/test_objc/ios/Runner/MyApi.h
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
NS_ASSUME_NONNULL_BEGIN

/// Implementation of the Pigeon generated interface Api.
@interface MyApi : NSObject <ACApi>
@interface MyApi : NSObject<ACApi>
@end

NS_ASSUME_NONNULL_END
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
#import "dartle.h"

/// Implementation of the Pigeon generated interface NestedApi.
@interface MyNestedApi : NSObject <ACNestedApi>
@interface MyNestedApi : NSObject<ACNestedApi>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a line of comment? So the next maintainer knows which parts are classes under test, which parts are test infrastructure.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file structure was a bit confusing. So MyNestedApi and MyApi are both implementations of the pigeon schema, how come that one has a file and this one's in MyFlutterViewController?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can have more than one schema which is the case for the pigeon file we are using to generate. One implementation I put in its own file, one I did not. I'll pull them both into the same file. Let me land this, it's blocking my other work and CI takes a long time. I'll address this in a followup.

- (ACSearchReply *)search:(ACNested *)input error:(FlutterError **)error;
@end

Expand Down